Merge pull request #766 from lidofinance/develop

Feature: Lido V2

.editorconfig

@@ -0,0 +1,13 @@
+# top-most EditorConfig file
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+indent_style = space
+indent_size = 4
+
+[*.{js,yml,json,cjs}]
+indent_size = 2
+max_line_length = 120

.eslintrc

@@ -1,59 +1,32 @@
 {
+  "plugins": ["prettier", "standard"],
   "env": {
     "node": true,
-    "es2020": true
+    "es2022": true
   },
-    "extends": [
-    "standard",
-    "plugin:prettier/recommended",
-    "prettier",
-    "prettier/standard"
-  ],
-"parser": "babel-eslint",
+  "extends": ["standard", "plugin:prettier/recommended"],
   "parserOptions": {
-    "ecmaVersion": 8,
-    "sourceType": "module",
+    "ecmaVersion": 2022,
+    "sourceType": "script",
     "ecmaFeatures": {
-      "jsx": true,
-      "modules": true
+      "jsx": true
     }
   },
-    "plugins": [
-    "node",
-    "prettier",
-    "standard"
-  ],
-
   "rules": {
     "prettier/prettier": "error",
-    "max-len": ["warn", { "code": 140, "ignoreComments": true, "ignoreUrls": true }],
-    "no-undef": "warn",
-    "no-unused-vars": "warn",
-    "prefer-const": "warn",
     "camelcase": "off",
-    "eol-last": "warn",
-    "no-multiple-empty-lines": "warn",
-    "comma-dangle": "warn",
     "quotes": ["error", "single", { "avoidEscape": true, "allowTemplateLiterals": true }],
     "jsx-quotes": ["error", "prefer-single"],
-    "no-useless-escape": "off",
-    "valid-jsdoc": "error",
-    "linebreak-style": ["error", "unix"]
+    "no-restricted-modules": ["error", {
+        "name": "@aragon/contract-helpers-test/src/asserts",
+        "message": "Please use helpers/assert instead."
+    }]
   },
   "overrides": [
     {
-      "files": [
-        "./scripts/{**/,}*.js",
-        "./test/{**/,}*.js",
-        "./e2e/test/{**/,}*.js"
-      ],
+      "files": ["./scripts/{**/,}*.js", "./test/{**/,}*.js", "./e2e/test/{**/,}*.js"],
       "env": {
         "mocha": true
-      },
-      "globals": {
-        "artifacts": "readonly",
-        "contract": "readonly",
-        "web3": "readonly"
       }
     }
   ]

.github/deployed-bytecode-consts.js

@@ -1,14 +1,13 @@
 const APPS_TO_NAMES = new Map([
   ['lido', 'Lido'],
   ['node-operators-registry', 'NodeOperatorsRegistry'],
-  ['oracle', 'LidoOracle']
 ])
 
 const CONTRACTS_TO_NAMES = new Map([
   ['wstethContract', 'WstETH'],
   ['executionLayerRewardsVault', 'LidoExecutionLayerRewardsVault'],
   ['compositePostRebaseBeaconReceiver', 'CompositePostRebaseBeaconReceiver'],
-  ['selfOwnedStETHBurner', 'SelfOwnedStETHBurner'],
+  ['burner', 'Burner'],
   ['depositor', 'DepositSecurityModule']
 ])
 

.github/workflows/analyse.yml

@@ -0,0 +1,81 @@
+name: Code Analysis
+
+on:
+  push:
+    branches: [master, develop]
+  pull_request:
+    branches: [master, develop]
+
+jobs:
+  slither:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      security-events: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+
+      - name: Setup node.js version
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16
+
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
+
+      - name: Cache yarn cache
+        id: cache-yarn-cache
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: yarn-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Cache node_modules
+        id: cache-node-modules
+        uses: actions/cache@v3
+        with:
+          path: '**/node_modules'
+          key: node_modules-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: node_modules-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Install modules
+        run: yarn
+        if: |
+          steps.cache-yarn-cache.outputs.cache-hit != 'true' ||
+          steps.cache-node-modules.outputs.cache-hit != 'true'
+
+      - uses: actions/setup-python@v4
+        with:
+          python-version: '3.10.6'
+
+      - name: Install poetry requirements
+        run: >
+          curl -sSL https://install.python-poetry.org | python - &&
+          poetry install --no-root
+      
+      - name: Remove foundry.toml
+        run: rm -f foundry.toml
+
+      - name: Run slither
+        run: >
+          poetry run slither . --sarif results.sarif --no-fail-pedantic
+
+      - name: Check results.sarif presence
+        id: results
+        if: always()
+        shell: bash
+        run: >
+          test -f results.sarif &&
+          echo 'value=present' >> $GITHUB_OUTPUT ||
+          echo 'value=not' >> $GITHUB_OUTPUT
+
+      - name: Upload SARIF file
+        uses: github/codeql-action/upload-sarif@v2
+        if: ${{ always() && steps.results.outputs.value == 'present' }}
+        with:
+          sarif_file: results.sarif