StETH: Add share-related math to transfer #3 #28

* Change transfer math to share-based * Additional checks in _transfer
lidofinance · Oct 22, 2020 · 31788c8 · 31788c8
1 parent 1d758db
commit 31788c8
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/contracts/0.4.24/StETH.sol b/contracts/0.4.24/StETH.sol
@@ -208,11 +208,12 @@ contract StETH is ISTETH, Pausable, AragonApp {
     * @param value The amount to be transferred.
     */
     function _transfer(address from, address to, uint256 value) internal {
-        require(value <= _shares[from]);
+        require(value != 0);
         require(to != address(0));
-
-        _shares[from] = _shares[from].sub(value);
-        _shares[to] = _shares[to].add(value);
+        uint256 sharesToTransfer = getSharesByPooledEth(value);
+        require(sharesToTransfer <= _shares[from]);
+        _shares[from] = _shares[from].sub(sharesToTransfer);
+        _shares[to] = _shares[to].add(sharesToTransfer);
         emit Transfer(from, to, value);
     }