fix/huge-voting-detection-after-restart #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BATMAH69
reviewed
Mar 21, 2024
| @@ -127,25 +126,32 @@ async function handleActiveVotes(blockEvent: BlockEvent, findings: Finding[]) { | |||
| } | |||
|
|
|||
| async function handleHugeVotes(blockEvent: BlockEvent, findings: Finding[]) { | |||
| const prevActiveVotes = await getActiveVotes(blockEvent.blockNumber - 1); | |||
There was a problem hiding this comment.
Is it possible to reduce call count?
BATMAH69
requested changes
Mar 21, 2024
BATMAH69
reviewed
Mar 22, 2024
| activeVotes = await getActiveVotes(currentBlock); | ||
|
|
||
| // Get previous block votes to correctly compare with the current one after the restart. | ||
| prevBlockVotes = await getActiveVotes(currentBlock - 1); |
There was a problem hiding this comment.
skip request if no active votes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bot detected the difference in votes based on the previous state of the block stored in memory. If the bot was restarted and the current block is the very first one, detection did not occur.