fix: Use mock in unit tests

lidofinance · Dec 27, 2023 · b843c19 · b843c19
1 parent 8fec062
commit b843c19
Show file tree

Hide file tree

Showing 9 changed files with 49 additions and 39 deletions.
diff --git a/ethereum-governance/src/common/__snapshots__/utils.spec.ts.snap b/ethereum-governance/src/common/__snapshots__/utils.spec.ts.snap
@@ -46,6 +46,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },
@@ -93,6 +94,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },
@@ -140,6 +142,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },

diff --git a/ethereum-governance/src/common/utils.spec.ts b/ethereum-governance/src/common/utils.spec.ts
@@ -1,7 +1,19 @@
 import { Finding, FindingSeverity, FindingType } from "forta-agent";
-import { mergeFindings, removeTimestamp } from "./utils";
+import { mergeFindings } from "./utils";
 
 describe("utils", () => {
+  let timeSpy: jest.SpyInstance;
+
+  beforeAll(() => {
+    timeSpy = jest.spyOn(Date, "now");
+    timeSpy.mockImplementation(() => new Date("2023-12-31"));
+  });
+
+  afterAll(() => {
+    jest.resetAllMocks();
+  });
+
+
   it("should merge findings", () => {
     const ids = ["SOME-CUTE-ALERT", "SOME-FAKE-ALERT", "SOME-SOSO-ALERT"];
     const wordsList = ["🌷🌷🌷", "🍯🍯🍯", "🌸🌸🌸"];
@@ -17,7 +29,7 @@ describe("utils", () => {
     });
 
     const reducedFindings = mergeFindings(findings);
-    expect(removeTimestamp(reducedFindings)).toMatchSnapshot();
+    expect(reducedFindings).toMatchSnapshot();
     expect(reducedFindings.length).toBe(3);
   });
 });
diff --git a/ethereum-governance/src/common/utils.ts b/ethereum-governance/src/common/utils.ts
@@ -151,14 +151,3 @@ export function eventSig(abi: string) {
   argsRaw.map((arg) => args.push(arg.trim().split(" ")[0]));
   return `${name}(${args.join(",")})`;
 }
-
-/**
- * Remove timestamp property from findings
- */
-
-export function removeTimestamp(findings: Array<object>): Array<object> {
-  findings.map((item: any) => {
-    delete item.timestamp;
-  });
-  return findings;
-}
diff --git a/ethereum-steth/src/common/__snapshots__/utils.spec.ts.snap b/ethereum-steth/src/common/__snapshots__/utils.spec.ts.snap
@@ -46,6 +46,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },
@@ -93,6 +94,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },
@@ -140,6 +142,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },

diff --git a/ethereum-steth/src/common/utils.spec.ts b/ethereum-steth/src/common/utils.spec.ts
@@ -1,7 +1,18 @@
 import { Finding, FindingSeverity, FindingType } from "forta-agent";
-import { mergeFindings, removeTimestamp } from "./utils";
+import { mergeFindings } from "./utils";
 
 describe("utils", () => {
+  let timeSpy: jest.SpyInstance;
+
+  beforeAll(() => {
+    timeSpy = jest.spyOn(Date, "now");
+    timeSpy.mockImplementation(() => new Date("2023-12-31"));
+  });
+
+  afterAll(() => {
+    jest.resetAllMocks();
+  });
+
   it("should merge findings", () => {
     const ids = ["SOME-CUTE-ALERT", "SOME-FAKE-ALERT", "SOME-SOSO-ALERT"];
     const wordsList = ["🌷🌷🌷", "🍯🍯🍯", "🌸🌸🌸"];
@@ -17,7 +28,7 @@ describe("utils", () => {
     });
 
     const reducedFindings = mergeFindings(findings);
-    expect(removeTimestamp(reducedFindings)).toMatchSnapshot();
+    expect(reducedFindings).toMatchSnapshot();
     expect(reducedFindings.length).toBe(3);
   });
 });
diff --git a/ethereum-steth/src/common/utils.ts b/ethereum-steth/src/common/utils.ts
@@ -151,14 +151,3 @@ export function eventSig(abi: string) {
   argsRaw.map((arg) => args.push(arg.trim().split(" ")[0]));
   return `${name}(${args.join(",")})`;
 }
-
-/**
- * Remove timestamp property from findings
- */
-
-export function removeTimestamp(findings: Array<object>): Array<object> {
-  findings.map((item: any) => {
-    delete item.timestamp;
-  });
-  return findings;
-}
diff --git a/ethereum-validators-set/src/common/__snapshots__/utils.spec.ts.snap b/ethereum-validators-set/src/common/__snapshots__/utils.spec.ts.snap
@@ -46,6 +46,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },
@@ -93,6 +94,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },
@@ -140,6 +142,7 @@ exports[`utils should merge findings 1`] = `
     "protocol": "ethereum",
     "severity": 2,
     "source": {},
+    "timestamp": 2023-12-31T00:00:00.000Z,
     "type": 3,
     "uniqueKey": "",
   },

diff --git a/ethereum-validators-set/src/common/utils.spec.ts b/ethereum-validators-set/src/common/utils.spec.ts
@@ -1,7 +1,18 @@
 import { Finding, FindingSeverity, FindingType } from "forta-agent";
-import { mergeFindings, removeTimestamp } from "./utils";
+import { mergeFindings } from "./utils";
 
 describe("utils", () => {
+  let timeSpy: jest.SpyInstance;
+
+  beforeAll(() => {
+    timeSpy = jest.spyOn(Date, "now");
+    timeSpy.mockImplementation(() => new Date("2023-12-31"));
+  });
+
+  afterAll(() => {
+    jest.resetAllMocks();
+  });
+
   it("should merge findings", () => {
     const ids = ["SOME-CUTE-ALERT", "SOME-FAKE-ALERT", "SOME-SOSO-ALERT"];
     const wordsList = ["🌷🌷🌷", "🍯🍯🍯", "🌸🌸🌸"];
@@ -17,7 +28,7 @@ describe("utils", () => {
     });
 
     const reducedFindings = mergeFindings(findings);
-    expect(removeTimestamp(reducedFindings)).toMatchSnapshot();
+    expect(reducedFindings).toMatchSnapshot();
     expect(reducedFindings.length).toBe(3);
   });
 });
diff --git a/ethereum-validators-set/src/common/utils.ts b/ethereum-validators-set/src/common/utils.ts
@@ -151,14 +151,3 @@ export function eventSig(abi: string) {
   argsRaw.map((arg) => args.push(arg.trim().split(" ")[0]));
   return `${name}(${args.join(",")})`;
 }
-
-/**
- * Remove timestamp property from findings
- */
-
-export function removeTimestamp(findings: Array<object>): Array<object> {
-  findings.map((item: any) => {
-    delete item.timestamp;
-  });
-  return findings;
-}