Ensure flagged users do not appear on TV #15481
Draft
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR does not compile. Please test the changes before setting the PR as being ready for review. |
ornicar
reviewed
Jun 12, 2024
| } | ||
| .foreach(_.addCandidate(g)) | ||
| userApi | ||
| .countEngines(g.userIds) |
There was a problem hiding this comment.
this adds a hit to the database every time a game starts, so about 5 million requests a day.
There was a problem hiding this comment.
Could you propose an alternative solution? I am asking out of curiosity as I am trying to get a better understanding of the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #14858, which highlights the problem of flagged accounts appearing on TV. The solution implemented ensures that users who are flagged will not be featured on TV.
Changes Made:
Credit to tors42 for providing the initial solution and code snippets.