Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15217: Board options missing on mobile web #15292

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

randompearl-stack
Copy link
Contributor

@randompearl-stack randompearl-stack commented May 12, 2024

boardopts.mov

Media query:

@include mq-is-col1 {
---main-max-width: calc(
100vh - #{$site-header-outer-height} - #{$col1-player-clock-height * 2} - #{$col1-moves-height}
);

or @media (max-width: 799.29px) and (orientation: portrait)

#15217

@ornicar
Copy link
Collaborator

ornicar commented May 13, 2024

Try it on an ongoing games. The prev/next buttons are now duplicated.

Obviously this button bar was not meant to be displayed here, that's why there are alternative prev/next buttons implemented around a horizontal move list.

159x396_2024-05-13

@randompearl-stack randompearl-stack marked this pull request as draft May 13, 2024 16:54
@randompearl-stack
Copy link
Contributor Author

randompearl-stack commented May 13, 2024

Appears the same for ongoing live and correspondence games on mobile now

Because live games do not have analysis the self-analysis div is replaced with a noop div, but this messes up the centering of the icons.

@randompearl-stack randompearl-stack marked this pull request as ready for review May 14, 2024 03:24
@ornicar
Copy link
Collaborator

ornicar commented May 14, 2024

Now this adds a full tool bar on play and watch UIs, which doesn't seem ideal or relevant to the issue.
And there still is no board option button that I can see:

901x558_2024-05-14

@randompearl-stack
Copy link
Contributor Author

Now this adds a full tool bar on play and watch UIs, which doesn't seem ideal or relevant to the issue.

I think I am misunderstanding you, how can be board options be added to mobile devices without a full tool bar?

And there still is no board option button that I can see:

The board option and analysis options were already on personal games on mobile, so I can remove them there and reinstate them to the initial tool bar like this:

Play:

Watch:

@randompearl-stack randompearl-stack marked this pull request as draft June 14, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants