don't hold the lock while emitting

lichess-org · Dec 28, 2024 · f6e8124 · f6e8124
1 parent 8704620
commit f6e8124
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/main/scala/util/Batcher.scala b/src/main/scala/util/Batcher.scala
@@ -35,10 +35,6 @@ final class Batcher[Key, Elem, Batch](
     if newBuffer.counter >= maxBatchSize then emitAndRemove(key)
 
   private def emitAndRemove(key: Key): Unit =
-    buffers.computeIfPresent(
-      key,
-      (_, buffer) =>
-        buffer.cancel()
-        emit(key, buffer.batch)
-        null
-    )
+    Option(buffers.remove(key)).foreach: buffer =>
+      buffer.cancel()
+      emit(key, buffer.batch)