normalize newlines in forms to CRLF #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP::Message < 7.00 normalized newlines in requests to CRLF. This has been removed. Based on the [HTML spec](https://html.spec.whatwg.org/#converting-an-entry-list-to-a-list-of-name-value-pairs) and [URL spec](https://url.spec.whatwg.org/#urlencoded-serializing), the CRLF normalization should be in the HTML layer. So the change in HTTP::Message is correct, and HTML::Form should be handling the normalization. Add normalization of lone \r or \n into \r\n, as defined in the HTML spec. Older HTTP::Message versions will do their own normalization. That will end up being a no-op, so we will still be compatible with those older versions.
haarg
force-pushed
the
haarg/crlf-normalize
branch
from
cd8038b to
63bf67a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 85.66% 85.68% +0.02%
==========================================
Files 9 9
Lines 544 545 +1
Branches 165 165
==========================================
+ Hits 466 467 +1
Misses 38 38
Partials 40 40 ☔ View full report in Codecov by Sentry. |
oalders
approved these changes
Oct 17, 2024
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Apr 12, 2025
Closes: https://bugs.gentoo.org/941756 See-also: libwww-perl/HTML-Form#53 See-also: libwww-perl/HTML-Form#50 See-also: libwww-perl/HTTP-Message#196 See-also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084899 Signed-off-by: Andreas K. Hüttel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP::Message < 7.00 normalized newlines in requests to CRLF. This has been removed. Based on the HTML
spec and URL spec, the CRLF normalization should be in the HTML layer. So the change in HTTP::Message is correct, and HTML::Form should be handling the normalization.
Add normalization of lone \r or \n into \r\n, as defined in the HTML spec.
Older HTTP::Message versions will do their own normalization. That will end up being a no-op, so we will still be compatible with those older versions.