Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vips::Image#close. #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Vips::Image#close. #340

wants to merge 1 commit into from

Conversation

ioquatix
Copy link
Member

I've been using this to help deal with memory usage issues.

@ioquatix ioquatix requested a review from jcupitt June 24, 2022 07:01
@Nakilon
Copy link
Contributor

Nakilon commented Jun 24, 2022

Hi. Just wondering. It is the thing that you've mentioned here? #67 (comment)
As I understand you said there it didn't help, only the GC.start did or something.

@ioquatix
Copy link
Member Author

Wow that was a while ago.

Well, I have not run the benchmarks again. That being said, in theory a close method makes sense. In practice, more work might be needed to make it practical/useful.

@jcupitt
Copy link
Member

jcupitt commented Jun 24, 2022

Hi, good idea, I've been meaning to add this.

Could we call it invalidate? That's the name we've used in the other libvips bindings.

close is rather close to post_close, the name we use for cleanup-on-finalize handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants