Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpsa: Update cacheless variable #177

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

joehandzik
Copy link
Member

There was a mistake here that I ran into on an H240 Smart Array card in RAID mode. I used the wrong naming scheme, missed it because my hardware was not available until recently.

Signed-off-by: Joe Handzik [email protected]

There was a mistake here that I ran into on an H240 Smart Array card in RAID mode. I used the wrong naming scheme, missed it because my hardware was not available until recently. 

Signed-off-by: Joe Handzik <[email protected]>
@joehandzik joehandzik added the bug label Aug 1, 2016
@joehandzik
Copy link
Member Author

Also, making a note of issues like this slipping in...this sort of error could be caught more easily if I could get you guys access to a dedicated HPE box somehow.

@tasleson
Copy link
Member

tasleson commented Aug 1, 2016

@joehandzik I'm working on changing the CI service components so that we can have multiple nodes which connect to a single coordinating node which is used as the contact point with github. The existing code is: https://github.com/tasleson/lsm-ci . The current architecture is too cumbersome as the end nodes require public connectivity (Restful API which uses ngrok). Hopefully I will have something better by the end of the week that we can leverage at multiple labs so that for every pull request we can run our tests automatically and that is self healing and tolerates intermittent node failures better.

@tasleson
Copy link
Member

tasleson commented Aug 1, 2016

I'm going to double check the automated runs at the SNIA lab. As it looks like we should re-role a release to pick up this change, is there anything else that needs a sanity test? The LED's be blinking OK right? :-)

@joehandzik
Copy link
Member Author

@tasleson Still gotta check that...I'll do that now.

@joehandzik
Copy link
Member Author

@tasleson Confirmed, LEDs work just fine!

@tasleson
Copy link
Member

tasleson commented Aug 1, 2016

@joehandzik Thanks! I'm going to roll a new release tomorrow AM, unless something else shows up when I'm looking through the logs at the lab.

@cathay4t cathay4t merged commit 7cdb2e1 into master Aug 2, 2016
@cathay4t
Copy link
Contributor

cathay4t commented Aug 2, 2016

This kind of bug could be found by pylint. I will try to enable pylint check in CI #180.

For this patch, it looks good. Merged. Thanks.

@cathay4t cathay4t deleted the joehandzik-update-cache-pct-unknown branch August 2, 2016 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants