Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for building with Winsock 1.1 (SDL 1.2) #42

Open
wants to merge 1 commit into
base: SDL-1.2
Choose a base branch
from

Conversation

ccawley2011
Copy link
Contributor

No description provided.

@sezero
Copy link
Contributor

sezero commented Jan 30, 2022

Why do we truly need this?

@sezero
Copy link
Contributor

sezero commented Jan 30, 2022

I mean, the windows version relies on iphlpapi.dll even in the SDL-1.2
branch which isn't available (at least by default as far as I know) on
w9x/nt4, so we certainly shouldn't care about winsock-1.x.

Closing. @slouken, @icculus: reopen and/or merge this if you disagree.

@sezero sezero closed this Jan 30, 2022
@ccawley2011
Copy link
Contributor Author

Why do we truly need this?

This is needed to support Windows 95 without the Winsock 2 upgrade installed.

I mean, the windows version relies on iphlpapi.dll even in the SDL-1.2 branch which isn't available (at least by default as far as I know) on w9x/nt4, so we certainly shouldn't care about winsock-1.x.

iphlpapi.dll is included with newer versions of Internet Explorer (which doesn't guarantee the existence of the Winsock 2 upgrade). In a Winsock 2 build, it'll be necessary to replace GetAdaptersInfo for UWP builds anyway (see issue #30), and while it would still be necessary to have GetAdaptersInfo in Winsock 1 builds, it would be better to address it in a separate PR.

@sezero
Copy link
Contributor

sezero commented Jan 30, 2022

OK then, leaving decision to @slouken and/or @icculus

@sezero sezero reopened this Jan 30, 2022
@sezero
Copy link
Contributor

sezero commented Jan 30, 2022

If this gets accepted though, note that one issue is this: #26
(original report at mxe/mxe#550), i.e.: iphlpapi.h needing ws2tcpip.h with some SDKs.

@slouken
Copy link
Collaborator

slouken commented Jun 16, 2022

We don't officially support Windows 95, but I think this is harmless. @ccawley2011, can you fix this PR so you don't reintroduce #26?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants