-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdl2: Update display name for PS5 DualSense Controller #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the analog trigger comments from the configuration file. The variables `input_l2_axis = "+4"` and `input_r2_axis = "+5"` were automatically generated by default, not manually added. It appears that the analog trigger issue (documented in RetroArch issue #6920) affects the UDEV and LINUXRAW controller drivers, but not the SDL2 driver. Given this new information, it would be advisable to revert your previous pull request (libretro#1142) which added a note about PS5 Controller L2/R2 triggers for the SDL2 driver.
davidhedlund
changed the title
sdl2/PS5 Controller.cfg -- revert comments for analog triggers
sdl2/PS5 Controller.cfg -- revert PR that added comments for analog triggers
Jul 19, 2024
davidhedlund
changed the title
sdl2/PS5 Controller.cfg -- revert PR that added comments for analog triggers
sdl2: Updated Aug 1, 2024
PS5 Controller.cfg
davidhedlund
changed the title
sdl2: Updated
sdl2: Update Aug 1, 2024
PS5 Controller.cfg
PS5 Controller.cfg
…t DualSense Wireless Controller.cfg remapped and renamed
davidhedlund
changed the title
sdl2: Update
sdl2: Update and rename Aug 3, 2024
PS5 Controller.cfg
PS5 Controller.cfg
to Sony Interactive Entertainment DualSense Wireless Controller.cfg
# Manually renamed from "PS5 Controller", see libretro/RetroArch#16868
RobLoach
reviewed
Aug 15, 2024
sdl2/Sony Interactive Entertainment DualSense Wireless Controller.cfg
Outdated
Show resolved
Hide resolved
…ontroller.cfg to PS5 Controller.cfg
davidhedlund
changed the title
sdl2: Update and rename
sdl2: Update Aug 20, 2024
PS5 Controller.cfg
to Sony Interactive Entertainment DualSense Wireless Controller.cfg
PS5 Controller.cfg
input_device_display_name = "PlayStation DualSense 5 Wireless Controller (PS5)"
davidhedlund
changed the title
sdl2: Update
[READY] sdl2: Update Aug 20, 2024
PS5 Controller.cfg
PS5 Controller.cfg
input_l2_axis_label = "L2 Analog" input_r2_axis_label = "R2 Analog"
Unnecessary input_device in autoconfig files generated by the android, and sdl2 controller drivers - libretro/RetroArch#16920
Removed the final comments
input_l2_axis_label = "L2 Trigger" input_r2_axis_label = "R2 Trigger"
restored `input_device = "PS5 Controller"`
RobLoach
changed the title
[READY] sdl2: Update
sdl2: Update display name for PS5 DualSense Controller
Sep 28, 2024
PS5 Controller.cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input_device_display_name
to clarify "PS5"