Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2: Update display name for PS5 DualSense Controller #1148

Merged
merged 17 commits into from
Sep 28, 2024

Conversation

davidhedlund
Copy link
Contributor

@davidhedlund davidhedlund commented Jul 19, 2024

  • Generated with RetroArch Flathub's release version 1.19.0
  • Added input_device_display_name to clarify "PS5"
  • Removed comments
  • Added " Trigger" to the labels for the triggers.

 Remove the analog trigger comments from the configuration file. The variables `input_l2_axis = "+4"` and `input_r2_axis = "+5"` were automatically generated by default, not manually added.

It appears that the analog trigger issue (documented in RetroArch issue #6920) affects the UDEV and LINUXRAW controller drivers, but not the SDL2 driver. Given this new information, it would be advisable to revert your previous pull request (libretro#1142) which added a note about PS5 Controller L2/R2 triggers for the SDL2 driver.
@davidhedlund davidhedlund changed the title sdl2/PS5 Controller.cfg -- revert comments for analog triggers sdl2/PS5 Controller.cfg -- revert PR that added comments for analog triggers Jul 19, 2024
@davidhedlund davidhedlund changed the title sdl2/PS5 Controller.cfg -- revert PR that added comments for analog triggers sdl2: Updated PS5 Controller.cfg Aug 1, 2024
@davidhedlund davidhedlund changed the title sdl2: Updated PS5 Controller.cfg sdl2: Update PS5 Controller.cfg Aug 1, 2024
…t DualSense Wireless Controller.cfg

remapped and renamed
@davidhedlund davidhedlund changed the title sdl2: Update PS5 Controller.cfg sdl2: Update and rename PS5 Controller.cfg to Sony Interactive Entertainment DualSense Wireless Controller.cfg Aug 3, 2024
@davidhedlund davidhedlund changed the title sdl2: Update and rename PS5 Controller.cfg to Sony Interactive Entertainment DualSense Wireless Controller.cfg sdl2: Update PS5 Controller.cfg Aug 20, 2024
input_device_display_name = "PlayStation DualSense 5 Wireless Controller (PS5)"
@davidhedlund davidhedlund changed the title sdl2: Update PS5 Controller.cfg [READY] sdl2: Update PS5 Controller.cfg Aug 20, 2024
input_l2_axis_label = "L2 Analog"
input_r2_axis_label = "R2 Analog"
Unnecessary input_device in autoconfig files generated by the android, and sdl2 controller drivers - libretro/RetroArch#16920
Removed the final comments
input_l2_axis_label = "L2 Trigger"
input_r2_axis_label = "R2 Trigger"
restored `input_device = "PS5 Controller"`
@RobLoach RobLoach changed the title [READY] sdl2: Update PS5 Controller.cfg sdl2: Update display name for PS5 DualSense Controller Sep 28, 2024
@RobLoach RobLoach merged commit 310edc0 into libretro:master Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants