Create android/Pro Controller.cfg #1066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Nintendo Switch Pro Controller (with nintendo-hid) # # This is the first fully working Android autoconfig # for Nintendo Switch Pro Controller as far as I know # It requires Android 12. # # Disclaimer: # The Nintendo Switch Pro Controller has other binding # for earliers Android versions. However, the Bluetooth # connectivity issue in Android 11 and earlier makes the # controller useless for gaming. # # Evaluated by David Hedlund.
# Requires Android 12 or later.
|
HI, what's the state of this? When is this PR ready for merge? |
It's ready. |
|
seems fine to me |
Removed comment
davidhedlund
changed the title
Make the file name match input_device
davidhedlund
changed the title
From https://github.com/libretro/retroarch-joypad-autoconfig/pull/1066/checks
How do we solve that? |
|
Duplicate vendor/product id pairs cause conflicts with RA. While it still "works", it can confuse the controller types. I'd honestly recommend just deleting People can use the 8BitDo controller in a different mode just fine. |
RobLoach
requested changes
Jan 25, 2024
davidhedlund
added a commit
to davidhedlund/retroarch-joypad-autoconfig
that referenced
this pull request
Jan 25, 2024
Concensus to solve https://github.com/libretro/retroarch-joypad-autoconfig/pull/1066/checks See libretro#1066 (comment) for discussion
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated from
RetroArch:
IDs
The file is a modified copy from udev/Create Nintendo - Switch Pro Controller.cfg, including:
However, currently, when I'm connecting the Nintendo Switch Pro Controller, RA pops up a "8BitDo SN30 Pro+ (Switch Mode) configured on port #1" (android/8BitDo_SN30_Pro_for_Android.cfg), and sometimes "Nintendo Switch Pro Controller configured on port #1" (sdl2/Nintendo Switch Pro Controller.cfg). So I'm a bit confused which ID that should be used.