Dealer: Improve disconnect #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, it makes sense to have that argument. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
roderickvd
previously approved these changes
Dec 15, 2024
photovoltex
commented
Dec 16, 2024
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
connect/src/spirc.rs:652
- The new behavior of pausing during disconnect should be covered by a test to ensure it works as expected.
if pause {
|
@roderickvd do you want to merge it or should I do it myself? (i unlinked the issue, as this adjustment doesn't seem to fix it and so is just an improvement) |
|
Go right ahead 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disconnecting now only handles disconnecting and not pausing/stopping. But because it feels unnatural to call disconnect on the
Spircand not having the player pause, the method now provides an additional option to explicitly pause.improves the behavior in #1419 but doesn't fix it