Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TESTING.md #1065

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update TESTING.md #1065

wants to merge 4 commits into from

Conversation

selankon
Copy link
Collaborator

Add a warning advising that latest lime packages breaks the interfaces configurations

Add a warning advising that latest lime packages breaks the interfaces configurations
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0c498f) 79.69% compared to head (528a28e) 79.71%.
Report is 4 commits behind head on master.

❗ Current head 528a28e differs from pull request most recent head 0758abb. Consider uploading reports for the commit 0758abb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   79.69%   79.71%   +0.02%     
==========================================
  Files          53       53              
  Lines        4550     4550              
==========================================
+ Hits         3626     3627       +1     
+ Misses        924      923       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@javierbrk javierbrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some grammar changes and a suggestion to include a link to a prebuilt OpenWRT 23 image.

TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
> Since the commit https://github.com/libremesh/lime-packages/commit/64b7c01961c6e7bc776f83523aea9264724b3b23 lime packages breaks the qemu image and the interfaces cannot be setted up!
> This is due the migration to newer version of OpenWRT.
> To use latest lime packages use a OpenWRT 23 image .

Copy link
Collaborator

@javierbrk javierbrk Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also add a link to a prebuilt OpenWRT 23 image.

Suggested change
>
> New prebuilt images can be downloaded from here:
> * https://repo.libremesh.org/releases/2023.1-rc2-ow22/targets/x86/64/libremesh-2023.1-rc2-ow22-default-x86-64-generic-rootfs.tar.gz
> * https://repo.libremesh.org/releases/2023.1-rc2-ow22/targets/x86/64/libremesh-2023.1-rc2-ow22-default-x86-64-generic-initramfs-kernel.bin

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should link non official repos here..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should link non official repos here..

also further testing has to be done... Let's leave this text behind

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added reference to official repo images

selankon and others added 3 commits November 17, 2023 09:52
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Copy link
Collaborator

@javierbrk javierbrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilario
Copy link
Member

ilario commented Nov 17, 2023

In my opinion, the solution is not to add a warning, but to fix the issue.
If you don't want to put the link to an external website, you can either:

@G10h4ck G10h4ck added this to the mesh-wide milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants