Links information module for shared state according to babeld

[javierbrk]

This module incorporates links information extracted from babel using ubus infrastructure.
The module has been tested in two librerouters and the output of the shared-state-async get babel_links_info in my setup is

    "lrprimero": [
        {
            "dst_ip": "fe80::aa40:41ff:fe1f:73ab",
            "iface": "eth1-2_17",
            "src_ip": "fe80::aa40:41ff:fe1f:723b"
        },
        {
            "dst_ip": "fe80::c24a:ff:fefc:3abd",
            "iface": "eth1-2_17",
            "src_ip": "fe80::aa40:41ff:fe1f:723b"
        }
    ],
    "lrsegundo": [
        {
            "dst_ip": "fe80::aa40:41ff:fe1f:723b",
            "iface": "eth1-2_17",
            "src_ip": "fe80::aa40:41ff:fe1f:73ab"
        },
        {
            "dst_ip": "fe80::c24a:ff:fefc:3abd",
            "iface": "eth1-2_17",
            "src_ip": "fe80::aa40:41ff:fe1f:73ab"
        }
    ]
}

[G10h4ck]

See my inline comments

[G10h4ck]

Better add an empty line here, between license and includes

[javierbrk]

done

[G10h4ck]

Why is this allocated outside the function?

[javierbrk]

It is a "cache" for IPV6 addresses

[javierbrk]

The idea is that each time the script is run this structure contains an empty list witch will be filled with each call to the get_ip method. Subsequent calls will use the information contained in the list.

[G10h4ck]

this function may fail, is it relevant to deal with the error conditions (for example an interface that miss IPv6 link local) ?

[javierbrk]

I have added a new test, for ci and also tested locally, there is no problem with that kind of error, the result will be an empty string (non existing interfaces and no ipv6). Do you think the function should report error explicitly ? If

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (4dc7f98) to head (f442b02).

❗ Current head f442b02 differs from pull request most recent head d4175d5. Consider uploading reports for the commit d4175d5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
+ Coverage   79.56%   79.59%   +0.03%     
==========================================
  Files          53       53              
  Lines        4566     4568       +2     
==========================================
+ Hits         3633     3636       +3     
+ Misses        933      932       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[G10h4ck]

should be ported to shared-state-async before merging