-
Notifications
You must be signed in to change notification settings - Fork 959
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Instead of relying on `protoc` and buildscripts, we generate the bindings using `pb-rs` and version them within our codebase. This makes for a better IDE integration, a faster build and an easier use of `rust-libp2p` because we don't force the `protoc` dependency onto them. Resolves #3024. Pull-Request: #3312.
- Loading branch information
Showing
141 changed files
with
3,652 additions
and
1,266 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -293,3 +293,30 @@ jobs: | |
echo "PR title is too long (greater than 72 characters)" | ||
exit 1 | ||
fi | ||
check-proto-files: | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
thomaseizinger
Contributor
|
||
name: Check for changes in proto files | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # v2.2.0 | ||
|
||
- run: cargo install --version 0.10.0 pb-rs --locked | ||
|
||
- name: Glob match | ||
uses: tj-actions/glob@v16 | ||
id: glob | ||
with: | ||
files: | | ||
**/generated/*.proto | ||
- name: Generate proto files | ||
run: pb-rs --dont_use_cow ${{ steps.glob.outputs.paths }} | ||
|
||
- name: Ensure generated files are unmodified # https://stackoverflow.com/a/5737794 | ||
run: | | ||
git_status=$(git status --porcelain) | ||
echo $git_status | ||
test -z "$git_status" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Should
protobuf-compilers
installation steps be removed as well?