Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Failing Tests due to RaisesGroup of Trio Package #482

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

mystical-prog
Copy link
Contributor

Issue with RaisesGroup

The failed tests were a result of deprecated keyword strict for trio.testing.RaisesGroup.

How was it fixed?

I updated the keywords from strict to allow_unwrapped and flatten_subgroups, and assigning value True to both, this fixed the failing tests but protobuf warnings still remain but it doesn't break the tests.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@pacrob
Copy link
Member

pacrob commented Oct 28, 2024

Looks good, @mystical-prog ! I just merged @kazzmir 's pr to fix the docs issue, so you if you rebase off main you should see those pass.

It looks like trio made the change in 0.26.0, so go ahead and move the pin in setup.py to >=0.26.0. Add a newsfragment, and it should be good to go!

@mystical-prog
Copy link
Contributor Author

I have made the necessary updates @pacrob
Let me know if there is anything else

@pacrob pacrob merged commit 62a0843 into libp2p:main Oct 29, 2024
17 checks passed
@mystical-prog mystical-prog deleted the trio-tests branch December 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants