Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove async-exit-stack dep, set pynacl dep to bottom pin only #468

Merged
merged 2 commits into from
May 27, 2024

Conversation

pacrob
Copy link
Member

@pacrob pacrob commented May 27, 2024

What was wrong?

We previously imported AsyncExitStack from async-exit-stack, but that's not needed as of py37.

Removed async-exit-stack dep

pynacl was set to ==1.3.0, opened to bottom pin only.

To-Do

  • Clean up commit history

Cute Animal Picture

image

@pacrob pacrob force-pushed the drop-async-exit-stack branch from 38cf5f1 to 283a15e Compare May 27, 2024 18:21
@pacrob pacrob force-pushed the drop-async-exit-stack branch from 789be87 to a27fb29 Compare May 27, 2024 18:30
@pacrob pacrob marked this pull request as ready for review May 27, 2024 18:32
@pacrob pacrob changed the title async-exit-stack was for pre-py37, just import from contextlib now remove async-exit-stack dep, set pynacl dep to bottom pin only May 27, 2024
@pacrob pacrob merged commit 0326e34 into libp2p:main May 27, 2024
17 checks passed
@pacrob pacrob deleted the drop-async-exit-stack branch May 27, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant