Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit 'listening' when relays change #2758

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Oct 9, 2024

To signal to the rest of libp2p that our addresses are changing, emit the listening event when relays go away or our reservation expires.

Also remove the old tags on startup to ensure we don't reconnect to old relays as the spec says the reservation is only valid while we are connected.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

To ensure we don't think we have a reserved slot on a relay, remove
the old tags on startup.
@achingbrain achingbrain requested a review from a team as a code owner October 9, 2024 13:09
@achingbrain achingbrain changed the title fix: remove old relay tags on start fix: emit 'listening' when relays change Oct 9, 2024
@achingbrain achingbrain merged commit 0d326d1 into main Oct 9, 2024
36 checks passed
@achingbrain achingbrain deleted the fix/remove-old-relay-tags-on-start branch October 9, 2024 16:32
@achingbrain achingbrain mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant