Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional topology filter #2544

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

achingbrain
Copy link
Member

Adds a filter option to topologies to allow filtering out duplicate notifications.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Adds a `filter` option to topologies to allow filtering out duplicate
notifications.
@achingbrain achingbrain requested a review from a team as a code owner May 14, 2024 08:52
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should we add tests for TopologyFilter ?

@achingbrain
Copy link
Member Author

The registrar test suite has new should use a filter... tests that exercise the code paths, using a PeerFilter which has type overlap with TopologyFilter so I think we're good there.

@achingbrain achingbrain merged commit 3c73707 into main May 15, 2024
25 checks passed
@achingbrain achingbrain deleted the feat/add-topology-filter branch May 15, 2024 11:33
@achingbrain achingbrain mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants