This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Fix out of date npms #21
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
reviewed
Apr 22, 2018
.aegir.js
Outdated
| webpack: { | ||
| resolve: { | ||
| alias: { | ||
| deepmerge$: path.resolve(__dirname, 'node_modules/deepmerge/dist/umd.js') |
There was a problem hiding this comment.
Do we really need deepmerge, can we replace it with lodash merge or defaultsDeep?
There was a problem hiding this comment.
Thanks for comment. Maybe we can replace deepmerge (Or, Object.assign() ?) . I'll investigate that.
There was a problem hiding this comment.
Object.assign does NOT do a deep merge.
There was a problem hiding this comment.
I tried to replace deepmerge to lodash.merge. It works and passed tests.
https://github.com/camelmasa/js-libp2p-keychain/commit/093711e21090e938e4f5fc50d12d1867c17e05fa
Should we replace the npm from deepmerge to lodash.merge ? If that is okay, I'll rebase commits in this PR.
|
I rebased commits. If it looks good, Please merge it 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated deepmerge and libp2p-crypto npms for dependencies out of date.
Also, I added
.aegir.jsfile for fixing deepmerge's issue. TehShrike/deepmerge#87We can choice to wait until fix the issue. Thought ?