accelerated-dht: cleanup peer from message sender on disconnection #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/cleanup-accelerated-dht
branch
from
de2d52f to
e6be480
Compare
gammazero
reviewed
Jan 4, 2025
fullrt/dht.go
Outdated
| if !ok { | ||
| return | ||
| } | ||
| defer dht.peerConnectednessSubscriber.Close() |
There was a problem hiding this comment.
Should this be moved up so that dht.peerConnectednessSubscriber.Close() gets called even if the type assertion returns false?
fullrt/dht.go
Outdated
Comment on lines
236
to
237
| } | ||
| if pc.Connectedness != network.Connected { |
There was a problem hiding this comment.
Suggested change
| } | |
| if pc.Connectedness != network.Connected { | |
| } else if pc.Connectedness != network.Connected { |
MarcoPolo
reviewed
Jan 7, 2025
MarcoPolo
approved these changes
Jan 9, 2025
gammazero
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.