PWX-35430: Honor cluster domains in round-robin balancer. #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityadani
force-pushed
the
PWX-35430
branch
from
cb71032 to
2671e3f
Compare
pp511
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
LGTM. Only caveat would be that in a Metro setup, nodes on the DR side which were participating in the roundrobin balancing will not be participating anymore. Which does reduce the number of nodes which will serve the request but sounds like the right thing to do.
- When the cluster is running with cluster-domains enabled, the round robin balancer should choose the nodes to forward the request within the same cluster domain. Signed-off-by: Aditya Dani <[email protected]>
adityadani
force-pushed
the
PWX-35430
branch
from
2671e3f to
7657420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a cluster is running with cluster-domains enabled, the round robin balancer should choose the nodes to forward the request within the same cluster domain.
Which issue(s) this PR fixes (optional)
PWX-35430
Testing Notes
Added two UTs that exercise the changed node selection logic based on whether a cluster domain is specified or not.