Skip to content

Commit

Permalink
configure.ac: Do not use '+=' to set CFLAGS to be POSIX-compliant
Browse files Browse the repository at this point in the history
The '+=' operator used in configure.ac to append to the CFLAGS variable
is present in Bash, but not the POSIX sh specification.
Therefore, the aforementioned part of the configure.ac (from which the
configure script is obtained) might not run correctly under non
Bash-like POSIX compliant shells (dash - default shell on Debian, ash,
etc).

Bug: https://bugs.gentoo.org/924200
Signed-off-by: Zurab Kvachadze <[email protected]>
  • Loading branch information
BalkanMadman authored and nikias committed Sep 14, 2024
1 parent f8be60c commit a2cafe2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if test "x$have_limd" = "xyes"; then
AC_SUBST(libimobiledevice_CFLAGS)
AC_SUBST(libimobiledevice_LIBS)
CACHED_CFLAGS="$CFLAGS"
CFLAGS+=" $libimobiledevice_CFLAGS"
CFLAGS="$CFLAGS $libimobiledevice_CFLAGS"
AC_CACHE_CHECK(for enum idevice_connection_type, ac_cv_enum_idevice_connection_type,
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
#include <libimobiledevice/libimobiledevice.h>
Expand Down

0 comments on commit a2cafe2

Please sign in to comment.