-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy options #2065
Merged
Merged
Add proxy options #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bording
force-pushed
the
proxy-options
branch
from
November 27, 2023 02:31
4d3c56e
to
01a6ccb
Compare
This was referenced Dec 3, 2023
Closed
Hi, This was my previous code, but this PR as mentioned is breaking.
As CredentialsProvider has been removed, I did try replacing it with this, but it failed.
Edit, Solved it. Given this change was about a proxy, i used ProxyOptions, but it turns out I didn't need it after all.
|
bgrainger
added a commit
to Faithlife/FaithlifeBuild
that referenced
this pull request
Jul 11, 2024
See libgit2/libgit2sharp#2065 for details of the breaking changes.
SIkebe
added a commit
to SIkebe/gitbucket-utility
that referenced
this pull request
Aug 20, 2024
SIkebe
added a commit
to SIkebe/gitbucket-utility
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ProxyOptions
class that can be used to specify proxy options to all of the relevant places where a proxy could be needed.ProxyType
is set toAuto
by default, so LibGit2Sharp will now respect any proxy settings configured in git.ProxyType
can be set toNone
to disable using the repo's proxy settings.Specified
let's you specify a a proxy URL. There are also callbacks to deal with credentials and certificate verification.As part of these changes,
CloneOptions
andSubmoduleUpdateOptions
have been updated to have all fetch-related options be exposed via aFetchOptions
property and not a confusing mix of some being directly on the class and others being only in an existingFetchOptions
property.I haven't added any proxy-specific automated tests here primarily because I don't currently know of a good way to have a proxy server spun up in GitHub Actions that I can reliably use on all platforms that need to be tested on.
For now, the manual testing I've done will have to be enough!