Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/windows build #2

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Feature/windows build #2

wants to merge 13 commits into from

Conversation

eisberg
Copy link

@eisberg eisberg commented Nov 2, 2020

Added Window Build

See new release in fork: https://github.com/ModelTech/php-geos/releases/tag/1.0.1

strk
strk reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

CREDITS
Sandro Santilli <[email protected]> - GEOS
J Smith <[email protected]> <[email protected]> - PHP packaging
Sandro Santilli [email protected] - GEOS
J Smith [email protected] [email protected] - PHP packaging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this format change ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of < > The RC resource compiler crashes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like an upstream bug. The current one does not crash, right ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the current version compiles without errors

README.md Show resolved Hide resolved
geos.c Show resolved Hide resolved
strk
strk requested changes Nov 16, 2020
View reviewed changes
README.md Show resolved Hide resolved
CREDITS
Sandro Santilli <[email protected]> - GEOS
J Smith <[email protected]> <[email protected]> - PHP packaging
Sandro Santilli [email protected] - GEOS
J Smith [email protected] [email protected] - PHP packaging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like an upstream bug. The current one does not crash, right ?

geos.c Show resolved Hide resolved
@nono303
Copy link

nono303 commented Nov 30, 2020

Many thanks @eisberg!
here my full patch for PHP8 based on your PR2
php-geos.zip

@nono303
Copy link

nono303 commented Jan 17, 2021

Hi,
Just updated config.w32 in my ModelTech@9df7f32 to have full functionality of libgeos

@javabudd
Copy link

Can we decouple the PHP8 functionality from this PR and introduce it as its own?

@nono303
Copy link

nono303 commented Feb 11, 2024 •
edited
Loading

Hi,
Here is a patch of the PR decoupled from PHP8 functionality php_geos-win.diff
(diff from https://github.com/nono303/php-geos)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strk strk strk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eisberg @nono303 @javabudd @strk @faytekin