Introduce dedicated publish workflow #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a dry-run here: https://github.com/d-e-s-o/libbpf-sys/actions/runs/10564387375 |
|
@alexforster can you take a look, please? Does it make sense to you? |
Introduce a dedicated workflow for publishing the crate by push of a button. This is a much nicer experience than having to push a tag, in my opinion, and there is no longer a need for mismatch check. Instead of the user having to create the tag, let GitHub Actions do it for us. Security-wise this reversal shouldn't matter: it's just meta-data attached to a commit, which we can easily verify that it hasn't changed. Because tags did not seem to be signed in past, we are not loosing anything there either by having a some piece of infrastructure do it. Signed-off-by: Daniel Müller <[email protected]>
danielocfb
force-pushed
the
topic/publish
branch
from
0d7390f
to
8ad638d
Compare
|
Thanks for the review. Going ahead with the merge to not block a new release for too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a dedicated workflow for publishing the crate by push of a button. This is a much nicer experience than having to push a tag, in my opinion, and there is no longer a need for mismatch check. Instead of the user having to create the tag, let GitHub Actions do it for us. Security-wise this reversal shouldn't matter: it's just meta-data attached to a commit, which we can easily verify that it hasn't changed. Because tags did not seem to be signed in past, we are not loosing anything there either by having a some piece of infrastructure do it.