fix missing blazesym head file #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There're some updates in Makefile in commit 4b20731. But it's not synchronized into CMakeLists.txt. It causes the error in below. 77%] Building C object CMakeFiles/profile.dir/profile.c.o libbpf-bootstrap/examples/c/profile.c:17:10: fatal error: blazesym.h: No such file or directory 17 | #include "blazesym.h" | ^~~~~~~~~~~~ compilation terminated. make[2]: *** [CMakeFiles/profile.dir/build.make:84: CMakeFiles/profile.dir/profile.c.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:520: CMakeFiles/profile.dir/all] Error 2 make: *** [Makefile:91: all] Error 2 Signed-off-by: Haojian Zhuang <[email protected]>
|
Looks good to me, thanks! |
danielocfb
pushed a commit
to danielocfb/libbpf-bootstrap
that referenced
this pull request
Mar 11, 2024
As libbpf#258 showed, we also have a CMake based build infrastructure lying around for the examples. However, currently it is not used in CI and, hence, prone to breakage. Change that fact by building using CMake as part of the build workflow. Signed-off-by: Daniel Müller <[email protected]>
danielocfb
pushed a commit
to danielocfb/libbpf-bootstrap
that referenced
this pull request
Mar 11, 2024
As libbpf#258 showed, we also have a CMake based build infrastructure lying around for the examples. However, currently it is not used in CI and, hence, prone to breakage. Change that fact by building using CMake as part of the build workflow. Signed-off-by: Daniel Müller <[email protected]>
anakryiko
pushed a commit
that referenced
this pull request
Mar 11, 2024
As #258 showed, we also have a CMake based build infrastructure lying around for the examples. However, currently it is not used in CI and, hence, prone to breakage. Change that fact by building using CMake as part of the build workflow. Signed-off-by: Daniel Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're some updates in Makefile in commit 4b20731. But it's not synchronized into CMakeLists.txt. It causes the error in below.
77%] Building C object CMakeFiles/profile.dir/profile.c.o
libbpf-bootstrap/examples/c/profile.c:17:10: fatal error: blazesym.h: No such file or directory
17 | #include "blazesym.h"
| ^~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/profile.dir/build.make:84: CMakeFiles/profile.dir/profile.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:520: CMakeFiles/profile.dir/all] Error 2
make: *** [Makefile:91: all] Error 2