Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selftests: override KHDR_INCLUDES var #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 13, 2024

  1. selftests: override KHDR_INCLUDES var

    In a recent series [1], I suggested to use KHDR_INCLUDES variable to
    avoid having to duplicate UAPI header files.
    
    The BPF CI builds the kernel in a separated directory -- KBUILD_OUTPUT
    variable is set and exported -- and the BPF selftests are executed
    directly, from the selftests/bpf directory, not from its parent. In thi
    s case, it is required to override KHDR_INCLUDES to look at the build
    directory, and not the kernel source, in 'usr/include'.
    
    Note that tools/testing/selftests/Makefile supports KBUILD_OUTPUT, but
    this Makefile is not used by the BPF CI: it directly uses the one from
    the bpf directory: tools/testing/selftests/bpf/Makefile. That's fine,
    KHDR_INCLUDES can be overridden, that should then fix the build issue
    seen in [1].
    
    Also, this KHDR_INCLUDES variable is not used by the BPF selftests
    before my series [1]. It is then fine to merge this modification before
    applying my modifications.
    
    Link: https://lore.kernel.org/bpf/20240816-ups-bpf-next-selftests-use-khdr-v1-0-1e19f3d5b17a@kernel.org/ [1]
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    781957b View commit details
    Browse the repository at this point in the history