Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More BSDs and native ARM64 #8

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

TheOneric
Copy link
Member

Alternatively we could drop arm64 and amd64 from libass-tests since they are (after libass/libass#866 ) already fully tested in the main repo

And enable sanitisers since the overhead is now bearable
This necessitates disabling ASAN since now ASLR
is neabled by default cuasing binaries to just abort
(with 0 return code!) after logging about the incompatibiltiy
@TheOneric TheOneric requested review from astiob and rcombs January 30, 2025 17:10
Copy link
Member

@rcombs rcombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing the arm64 build if running it here isn't adding anything, but don't think we need to block the merge on that.

@TheOneric TheOneric merged commit e924681 into libass:master Jan 31, 2025
9 checks passed
@TheOneric TheOneric deleted the native-arm+bsds branch January 31, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants