upload report and install deps correctly

liamdebeasi · Nov 14, 2023 · c798f34 · c798f34
1 parent 066d66e
commit c798f34
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -4,6 +4,9 @@ on:
   push:
     branches:
       - '*'
+  pull_request:
+    branches:
+      - '*'
 
 concurrency:
   # Cancel in progress runs for this branch
@@ -22,11 +25,17 @@ jobs:
         with:
           version: 8
       - name: Install Dependencies
-        run: pnpm install && pnpm playwright install
+        run: pnpm install && pnpm playwright install --with-deps
         shell: sh
       - name: Build Application
         run: pnpm run build
         shell: sh
       - name: Run Tests
         run: pnpm run test
-        shell: sh
+        shell: sh
+      - uses: actions/upload-artifact@v3
+        if: always()
+        with:
+          name: playwright-report
+          path: playwright-report/
+          retention-days: 30
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -70,7 +70,7 @@ export default defineConfig({
 
   /* Run your local dev server before starting the tests */
   webServer: {
-    command: 'pnpm run build && pnpm serve dist',
+    command: 'pnpm serve dist',
     url: 'http://127.0.0.1:3000',
     reuseExistingServer: !process.env.CI,
   },