✨ add constaint diffs to BuildPage panel #1731
Merged
+1,126
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 390b700 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Updates to Preview Branch (feat/diff-constaint) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
junkisai
changed the title
CI Feedback 🧐(Feedback updated until commit 390b700)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
junkisai
force-pushed
the
feat/diff-constaint
branch
from
927620b to
9ed3f92
Compare
junkisai
requested review from
hoshinotsuyoshi,
FunamaYukina,
MH4GF and
NoritakaIkeda
and removed request for
a team
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||
![qodo-merge-pro-for-open-source[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
frontend/packages/db-structure/src/diff/constraints/buildConstaintColumnNameDiffItem.ts
Outdated
Show resolved
Hide resolved
junkisai
force-pushed
the
feat/diff-constaint
branch
from
9ed3f92 to
039407f
Compare
Comment on lines
11
to
18
| import { buildConstaintDeleteConstraintDiffItem } from './constraints/buildConstaintDeleteConstraintDiffItem.js' | ||
| import { buildConstaintDetailDiffItem } from './constraints/buildConstaintDetailDiffItem.js' | ||
| import { buildConstaintNameDiffItem } from './constraints/buildConstaintNameDiffItem.js' | ||
| import { buildConstaintTargetColumnNameDiffItem } from './constraints/buildConstaintTargetColumnNameDiffItem.js' | ||
| import { buildConstaintTargetTableNameDiffItem } from './constraints/buildConstaintTargetTableNameDiffItem.js' | ||
| import { buildConstaintUpdateConstraintDiffItem } from './constraints/buildConstaintUpdateConstraintDiffItem.js' | ||
| import { buildConstraintColumnNameDiffItem } from './constraints/buildConstraintColumnNameDiffItem.js' | ||
| import { buildConstaintDiffItem } from './constraints/buildConstraintDiffItem.js' |
There was a problem hiding this comment.
Function name and file name may be “Constaint” instead of "Constraint"💭
There was a problem hiding this comment.
My eyes skimmed over it and I easily missed the typo, so I really appreciate your pointing it out. 🙏
🐛 fix typo in buildConstraintDiffItem function and related imports
There was a problem hiding this comment.
There seems to be a little more left!🙏
There was a problem hiding this comment.
It looks like I got all the file names wrong... I'll go ahead and fix them! 🙏
There was a problem hiding this comment.
I believe I’ve finally fixed everything this time. 🙇
There was a problem hiding this comment.
Thank you very much! I think it is perfect!✅
Refactor GridTable components to accept a className prop, allowing for additional styling flexibility. This change improves the customization options for users of the GridTable component while maintaining existing functionality.
Upgrade zod to version 3.24.3 across multiple dependencies in pnpm-lock.yaml to ensure compatibility and leverage improvements. Additionally, add ts-pattern version 5.7.0 to the db-structure package.json, enhancing functionality and type safety in the project.
Implement new utilities for handling constraint-related schema differences, including buildConstraintDiffItem, buildConstaintNameDiffItem, buildConstaintColumnNameDiffItem, buildConstaintTargetTableNameDiffItem, buildConstaintTargetColumnNameDiffItem, buildConstaintUpdateConstraintDiffItem, buildConstaintDeleteConstraintDiffItem, and buildConstaintDetailDiffItem. Update existing types and constants to support these functionalities, ensuring comprehensive type safety and consistency in the schema diff utilities.
Implement the ConstraintList component to display various types of constraints (Primary Key, Foreign Key, Unique, Check) in the schema diff view. Introduce new ConstraintItem components for each constraint type, enhancing the organization and readability of the diff view. Update TableItem and TableDiffBlock components to support collapsible functionality for constraints, ensuring a consistent layout and improved user experience.
…aint column name diff Correct the spelling of 'CheckConstarintDetail' to 'CheckConstraintDetail' across multiple files for consistency. Introduce a new utility function, 'buildConstraintColumnNameDiffItem', to handle schema differences related to constraint column names, enhancing the overall functionality of the schema diff utilities.
Correct the spelling of 'buildConstaintDiffItem' to 'buildConstraintDiffItem' in the buildSchemaDiff.ts and buildConstraintDiffItem.ts files for consistency and accuracy. This change enhances code readability and maintains naming conventions across the schema diff utilities.
junkisai
force-pushed
the
feat/diff-constaint
branch
from
039407f to
0d23379
Compare
FunamaYukina
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
This PR introduces diff representation for table constraints in the schema-comparison views.
Key Points
Constraint-level diff utilities
buildPrimaryKeyDiffItem,buildForeignKeyDiffItem,buildUniqueConstraintDiffItem,buildCheckConstraintDiffItem, andbuildNotNullConstraintDiffItem.getChangeStatusto resolve constraint IDs and filter by(tableId, constraintId).Typed models & constants
ConstraintDiffItemand related enumerations for strict type safety.What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at 9ed3f92
Detailed Changes
29 files
Add constraint-related diff item builders and integrationAdd constraint path patterns for diff matchingAdd builder for constraint column name diff itemAdd builder for constraint delete action diff itemAdd builder for check constraint detail diff itemAdd builder for constraint name diff itemAdd builder for constraint target column diff itemAdd builder for constraint target table diff itemAdd builder for constraint update action diff itemAdd builder for base constraint diff itemAdd constraint diff item types and enumsExtend getChangeStatus to support constraintIdExport constraint diff types from package entrypointExport constraint and check detail typesAdd types for constraint name and check constraint detailAdd ConstraintList UI for rendering constraint diffsAdd styles for ConstraintList and sectionsAdd CheckConstraintItem UI for check constraintsAdd ForeignConstraintItem UI for foreign key constraintsAdd PrimaryConstraintItem UI for primary key constraintsAdd UniqueConstraintItem UI for unique constraintsAdd helper for constraint diff status stylingAdd icon styles for constraint itemsExport all constraint item componentsExport ConstraintList componentIntegrate ConstraintList into TableItem, add collapsibleAdd constraint section open/close state to TableDiffBlockAdd className prop support to GridTable componentsAdd constraints property to table mock data2 files
Add ts-pattern dependency, update zod versionUpdate lockfile for new/updated dependencies1 files
Add changeset for constraint diff utilities/types1 files
Additional Notes