Skip to content

feat: add tseslint.configs.recommendedTypeChecked and remove no-unsafe-member-access rule #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: add tseslint.configs.recommendedTypeChecked and remove no-unsafe-member-access rule #1657

wants to merge 6 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add TypeScript ESLint Type-Checked Configuration

Changes

  • Added tseslint.configs.recommendedTypeChecked rules to the ESLint configuration
  • Removed the explicit @typescript-eslint/no-unsafe-member-access rule since it's included in the type-checked configuration
  • Verified that linting passes with the new configuration

Testing

  • Ran pnpm lint to verify the changes work correctly
  • Confirmed that the warnings about unused eslint-disable directives for no-unsafe-member-access appear, indicating the rule is now properly included in the type-checked configuration

Link to Devin run

https://app.devin.ai/sessions/f6b5ffd6a6e94107891d3a2ee8fe65da

Requested by: [email protected]

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner May 12, 2025 05:54
@devin-ai-integration devin-ai-integration bot requested review from hoshinotsuyoshi, FunamaYukina, junkisai, MH4GF and NoritakaIkeda and removed request for a team May 12, 2025 05:54
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 12, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 865c8a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@liam-hq/configs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liam-app ❌ Failed (Inspect) May 12, 2025 7:07am
liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 7:07am
liam-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 7:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
liam-docs ⬜️ Ignored (Inspect) Visit Preview May 12, 2025 7:07am

@supabase Supabase
Copy link

supabase bot commented May 12, 2025 •
edited
Loading

Updates to Preview Branch (devin/1747029117-add-type-checked-eslint) ↗︎

Deployments Status Updated
Database ✅ Mon, 12 May 2025 07:04:16 UTC
Services ✅ Mon, 12 May 2025 07:04:16 UTC
APIs ✅ Mon, 12 May 2025 07:04:16 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations ✅ Mon, 12 May 2025 07:04:17 UTC
Migrations ✅ Mon, 12 May 2025 07:04:19 UTC
Seeding ✅ Mon, 12 May 2025 07:04:19 UTC
Edge Functions ✅ Mon, 12 May 2025 07:04:19 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@MH4GF MH4GF marked this pull request as draft May 12, 2025 05:54
@MH4GF
chore: update ESLint configurations and dependencies
f7eeb35 
- Removed tsconfigPath from ESLint configurations across multiple packages.
- Updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser to version 8.32.0.
- Added typescript-eslint as a new dependency in the configs package.
- Refactored ESLint base configuration to utilize global ignores and improved TypeScript support.

Co-Authored-By: [email protected] <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

frontend/packages/prompt-test result:

visit: https://cloud.langfuse.com/project/cm8ii4o5o03fpad078o638g1d/datasets/cm99wciaz070ead07rgjr88ou/runs/cmakqm9pf0026ad07s3hmwu9o

run items length
3

@qodo-merge-pro-for-open-source Qodo Merge Pro for Open Source
Copy link
Contributor

qodo-merge-pro-for-open-source bot commented May 12, 2025 •
edited
Loading

CI Feedback 🧐

(Feedback updated until commit fe247bb)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: frontend-ci

Failed stage: Run /./.github/actions/pnpm-setup [❌]

Failure summary:

The action failed because the pnpm-lock.yaml file is out of sync with the package.json file in the
frontend/packages/configs directory. Specifically, the version of @typescript-eslint/parser in
package.json is specified as 8.32.0, but in the lockfile it's specified as ^8.32.0 (with a caret
indicating a range rather than an exact version).

Relevant error logs: 
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

147:  ##[endgroup]
148:  [command]/home/runner/setup-pnpm/node_modules/.bin/pnpm store path --silent
149:  /home/runner/setup-pnpm/node_modules/.bin/store/v10
150:  pnpm cache is not found
151:  ##[group]Run pnpm install --frozen-lockfile --prefer-offline
152:  �[36;1mpnpm install --frozen-lockfile --prefer-offline�[0m
153:  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
154:  env:
155:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
156:  ##[endgroup]
157:  Scope: all 18 workspace projects
158:  ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with <ROOT>/frontend/packages/configs/package.json
159:  Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"
160:  Failure reason:
161:  specifiers in the lockfile ({"@biomejs/biome":"1.9.4","@eslint/compat":"1.2.9","@tsconfig/strictest":"2.0.5","@typescript-eslint/parser":"^8.32.0","eslint":"9.25.1","typescript-eslint":"8.32.0"}) don't match specs in package.json ({"@biomejs/biome":"1.9.4","@eslint/compat":"1.2.9","@tsconfig/strictest":"2.0.5","@typescript-eslint/parser":"8.32.0","eslint":"9.25.1","typescript-eslint":"8.32.0"})
162:  ##[error]Process completed with exit code 1.
163:  Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoshinotsuyoshi hoshinotsuyoshi Awaiting requested review from hoshinotsuyoshi hoshinotsuyoshi is a code owner automatically assigned from liam-hq/liam-dev

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina is a code owner automatically assigned from liam-hq/liam-dev

@junkisai junkisai Awaiting requested review from junkisai junkisai is a code owner automatically assigned from liam-hq/liam-dev

@MH4GF MH4GF Awaiting requested review from MH4GF MH4GF is a code owner automatically assigned from liam-hq/liam-dev

@NoritakaIkeda NoritakaIkeda Awaiting requested review from NoritakaIkeda NoritakaIkeda is a code owner automatically assigned from liam-hq/liam-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MH4GF