Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block quote handling #76

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix block quote handling #76

merged 1 commit into from
Nov 1, 2024

Conversation

lhh
Copy link
Owner

@lhh lhh commented Nov 1, 2024

When generating a template from an issue, if a line in the description of the issue or a subtask had a trailing space, python yaml would encode the whole thing as a quoted string instead of a block-quote like it should have been.

By iterating through the text and stripping off trailing whitespace, first on the whole, then on each line individually, this issue is resolved.

Related to: yaml/pyyaml#121

Found / original patch by Jon Schlueter @yazug

When generating a template from an issue, if a line in the
description of the issue or a subtask had a trailing space,
python yaml would encode the whole thing as a quoted string
instead of a block-quote like it should have been.

By iterating through the text and stripping off trailing
whitespace, first on the whole, then on each line individually,
this issue is resolved.

Related to: yaml/pyyaml#121

Found / original patch by Jon Schlueter
Copy link
Collaborator

@yazug yazug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@lhh lhh merged commit 6d13061 into main Nov 1, 2024
4 checks passed
@lhh lhh deleted the yaml_sanity branch November 11, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants