Mash-like distances #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lh3, and thanks for another brilliant tool.
I recently found myself needing to calculate something like a mash distance from a bunch of kmer profiles I'd made with Yak, and so implemented a simple profile distance calculator into yak.
Currently it's not as efficient as it could be, but if this is something you would like to see implemented then I'd be happy to tidy it up and fix some of the more egregiously inefficient parts and then make a PR.
If not, and anyone needs this functionality, it will live in its current state in my fork, just be aware it was made as a one-off and has not been reviewed, so if it breaks you get to keep both pieces. My coding is far from what you're used to from @lh3
Best,
Kevin