-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented gamepad support #446
base: master
Are you sure you want to change the base?
Conversation
KonstantinKohl
commented
Oct 23, 2019
- updated control scheme to handle gamepad (tested with xbox, but any gamepad with compatible layout should work)
- modified camera to gracefully handle gamepad controls vs. mouse
Konstantin Kohl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Great work on this. On our next release we have separated manual control sensor into device controls. We will have keyboard control, wheel control and will use this to create a game pad control. |
@EricBoiseLGSVL in this case I'd suggest we skip my request, as the merging will likely be pretty messy. Do you have an eta for the next release, and will gamepad control already be part of this? |
Steering wheel control is in latest 2019.10-rc1 release. The code is available in current master. |
I don't have an ETA on gamepad control but the wheel control and keyboard control sensor code is a great template on how to add unique device controls without merge issues. I'd refactor and submit a new request. If you wait until we add it, it will probably be in a few release cycles. |
@KonstantinKohl will you be able to update pull request and make game pad sensor implemention similar to Keyboard and Steering Wheel sensors? I can safely promise that we will merge that if it complies with new approach having independent sensor for each type of input. BR |
@zelenkovsky yes I still want to do this. Would you prefer if I did this before or after your next release? I was currently waiting for your next release, on which I would then base my changes on, but I can also do it on the current latest master. In any case, I wouldn't be able to start working on this before early next week. |
Just saw the new version got released. I'll look into rebuilding the controller input as soon as I have the time. |