Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add tox-run action and workflow #89

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Feat: Add tox-run action and workflow #89

merged 1 commit into from
Jan 31, 2024

Conversation

eb-oss
Copy link
Contributor

@eb-oss eb-oss commented Jan 11, 2024

No description provided.

@eb-oss eb-oss added the enhancement New feature or request label Jan 11, 2024
@eb-oss
Copy link
Contributor Author

eb-oss commented Jan 16, 2024

@keanjapesan @tykeal Please review the newest changes. To keep incremental changes clear, I'll keep each change as a separate commit until merge, and then squash them once it's good to go.

@jwagantall
Copy link
Contributor

@MightyNerdEric , can we add a step to allow people to trigger a pre-build script if exists?
I did something like that here:
https://github.com/lfit/releng-reusable-workflows/pull/90/files#diff-1ca8ce5124ebfd189098028c2c6fee78a37e8c8cd457a09cf69e356687bc74a0R72

ONAP and ORAN are both using this and they could benefit from having this option

@eb-oss
Copy link
Contributor Author

eb-oss commented Jan 18, 2024

@MightyNerdEric , can we add a step to allow people to trigger a pre-build script if exists? I did something like that here: https://github.com/lfit/releng-reusable-workflows/pull/90/files#diff-1ca8ce5124ebfd189098028c2c6fee78a37e8c8cd457a09cf69e356687bc74a0R72

ONAP and ORAN are both using this and they could benefit from having this option

@jwagantall I've added the ability for a pre-build script path to be provided to the action. Please let me know if it looks like it does what you need.

@eb-oss eb-oss requested a review from tykeal January 30, 2024 23:33
@eb-oss eb-oss enabled auto-merge January 31, 2024 17:55
@eb-oss eb-oss merged commit dde691a into lfit:main Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tykeal tykeal tykeal approved these changes

@keanjapesan keanjapesan keanjapesan approved these changes

@jwagantall jwagantall jwagantall approved these changes

@vvalderrv vvalderrv Awaiting requested review from vvalderrv

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eb-oss @jwagantall @tykeal @keanjapesan