Fix: Disable the bash echo with +x #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykeal
requested changes
Dec 5, 2023
askb
changed the title
|
recheck |
I've tested this locally works correctly! Once merged will test with the reusable workflows. |
|
recheck |
askb
changed the title
askb
changed the title
jwagantall
approved these changes
Dec 5, 2023
::add-mask:: disables the output however the GHA steps through the echo in the run. Therefore avoid sensitive data being echo-ed in the logs being disabled add +x as the last arg to bash. Export only required vars into environment. Signed-off-by: Anil Belur <[email protected]>
tykeal
approved these changes
Dec 5, 2023
jwagantall
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::add-mask:: disables the output however the GHA steps through
the echo in the run. Therefore avoid sensitive data being
echo-ed in the logs being disabled add +x as the last arg
to bash.
Export only required vars into environment.
Signed-off-by: Anil Belur [email protected]