Fix: Install setuptools for tox jobs with py3.12 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxiiro
reviewed
Jun 5, 2024
The lftools license check fails the tox run with python 3.12. The default version of the python used in the tox workflow using python 3.12. Python 3.12 does not come with a stdlib distutils module (changelog), because distutils was deprecated in 3.10 and removed in 3.12. See PEP 632 – Deprecate distutils module. Therefore, check if python 3.12 and install distutils before the run. Ref: https://docs.python.org/3/whatsnew/3.12.html https://peps.python.org/pep-0632/ Issue: RELENG-5403 Signed-off-by: Anil Belur <[email protected]>
tykeal
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lftools license check fails the tox run with python 3.12.
The default version of the python used in the tox workflow using python 3.12. Python 3.12 does not come with a stdlib distutils module (changelog), because distutils was deprecated in 3.10 and removed in 3.12. See PEP 632 – Deprecate distutils module.
Therefore, check if python 3.12 and install distutils before the run.
Ref:
https://docs.python.org/3/whatsnew/3.12.html
https://peps.python.org/pep-0632/
Issue: RELENG-5403