Feat/partnership #96

Marchand-Nicolas · 2023-07-13T14:23:09Z

vercel · 2023-07-13T14:23:14Z

@Marchand-Nicolas is attempting to deploy a commit to the StarknetID Team on Vercel.

To accomplish this, @Marchand-Nicolas needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

fricoben

Bonne PR ! Il me faut plus de rigueur sur les types et de la simplification sur la gestion de ton CSS qui me parait bcp trop complexe (tu utilises trop de logique avec des class dynamique alors que tu devrais utiliser les fonctionnalités de css directement pour ça).

fricoben · 2023-07-14T13:20:31Z

components/UI/box.tsx

+import React from "react";
+import styles from "../../styles/components/box.module.css";
+
+const Box = ({ children }: { children: React.ReactNode }) => {


Nope ici tu dois definir un type Box et l'utiliser derrière.

Tous les autres composants ont été crées de cette manière tu peux prendre l'exemple de reward.ts.

Ici ça donnerait

type RewardProps = { children: ReactNode }; const Box: FunctionComponent<BoxProps> = ({ children, }) => {

De plus au niveau du type tu peux importer ReactNodeau lieu de faire React.ReactNode

fricoben · 2023-07-14T13:20:40Z

components/UI/stats/statElement.tsx

+import styles from "../../../styles/components/stats.module.css";
+import Box from "../box";
+
+const StatElement = ({ name, value }: { name: string; value: string }) => {


meme chose il me faut un type

fricoben · 2023-07-14T13:20:43Z

components/UI/stats/stats.tsx

+const Stats = ({
+  title,
+  stats,
+}: {


meme chose il me faut un type

fricoben · 2023-07-14T13:22:55Z

components/shapes/crosses.tsx

+import styles from "../../styles/components/shapes.module.css";
+import Cross from "./cross";
+
+const Crosses = ({


meme chose il me faut un type

fricoben · 2023-07-14T13:23:12Z

components/animations/onScrollIntoView.tsx

+import React from "react";
+import { useInView } from "react-intersection-observer";
+import styles from "../../styles/components/animations.module.css";
+const OnScrollIntoView = ({


meme chose il me faut un type + saute une ligne

fricoben · 2023-07-14T13:30:08Z

pages/partnership.tsx

+                title="They worked with us"
+                corner={null}
+              />
+              <div className={styles.partnersContainer}>


Je pense que y'a du css à changer ici vu les commentaires que je t'ai fait sur discord

fricoben · 2023-07-14T13:31:12Z

pages/index.tsx

@@ -73,6 +76,44 @@ const Quests: NextPage = () => {
            <QuestsSkeleton />
          )}
        </div>
+        <section>


A mettre dans un composant à part. (ce composant ne se trouvera pas dans un le folder /UI car on l'utilisera seulement ici mais c'est à mon avis plus clean

fricoben · 2023-07-14T13:32:04Z

components/shapes/crosses.tsx

+          }}
+          className={styles.side}
+        >
+          {Array.from(Array(number).keys()).map((i) => (


trop compliqué ici essaye de simplifier.

fricoben · 2023-07-14T13:32:13Z

components/shapes/crosses.tsx

+          }}
+          className={styles.side}
+        >
+          {Array.from(Array(number).keys()).map((i) => (


fricoben · 2023-07-14T13:32:46Z

components/animations/onScrollIntoView.tsx

+        styles.onScrollIntoView,
+        styles[animation],
+        inView ? styles.active : "",
+      ].join(" ")}


Pourquoi la class est si grande et complexe ?

vercel · 2023-07-16T09:24:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
goerli-starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2023 2:47pm
starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2023 2:47pm

…3742281

fricoben

Good ! Encore quelques trucs à changer.

fricoben · 2023-07-16T15:29:39Z

components/UI/titles/categoryTitle.tsx

+  return (
+    <div className={styles.container}>
+      {corner && (
+        <div className={[styles.corner, styles[corner]].join(" ")}>


Ok je vois donc là ici pour moi tu dois typer le corner de manière à ce qu'on comprenne que ce n'est pas une string mais un type Corner = bottomRight | bottomLeft | topRight | topLeft

de cette manière on comprend à quoi ça sert.

fricoben · 2023-07-16T15:31:43Z

components/UI/titles/categoryTitle.tsx

+          <Corner />
+        </div>
+      )}
+      {squares && (


Pareil sur le type de square.

fricoben · 2023-07-16T15:31:52Z

components/UI/titles/mainTitle.tsx

+  title: string;
+  highlighted: string;
+  subtitle: string;
+  corner?: string | null;


Pareil ici et pour la props squares

fricoben · 2023-07-16T15:43:45Z

components/shapes/dots.tsx

+import styles from "../../styles/components/shapes.module.css";
+import Dot from "./dot";
+
+const Dots = ({ number = 5 }: { number?: number }) => {


Type ici pareil que la dernière fois

fricoben · 2023-07-16T15:45:06Z

pages/api/get_quests.ts

@@ -32,6 +32,7 @@ export default async function handler(
        .json({ error: "No quests found" });
    }
  } catch (error) {
+    console.log(error);


fricoben · 2023-07-16T15:45:26Z

pages/partnership.tsx

+import OnScrollIntoView from "../components/animations/onScrollIntoView";
+
+const Partnership: NextPage = () => {
+  const { View: JediSwapView, play: jediSwapPlay } = useLottie({


JediSwap c'est pas un bon naming tu peux dire que c'est une illustration ou un visuel ou un media mais partout ou tu met jediswap moi je suis perdu

fricoben · 2023-07-16T16:02:53Z

pages/partnership.tsx

+              <div className={styles.partnersContainer}>
+                <img src="/partners/braavosLogo.svg" />
+                <img src="/partners/zklendLogo.svg" />
+                <img src="/partners/SithswapLogo.svg" />


naming sans majuscule, sithswapLogo

fricoben · 2023-07-16T16:03:15Z

pages/partnership.tsx

+                <img src="/partners/zklendLogo.svg" />
+                <img src="/partners/SithswapLogo.svg" />
+                <img src="/partners/JEDIswapLogo.svg" />
+                <img src="/partners/AVNULogo.svg" />


Pareil ici pas de majuscule

fricoben · 2023-07-16T16:06:23Z

pages/partnership.tsx

+            <CategoryTitle
+              title="Starknet Quests Lead the Way"
+              subtitle="Revolutionizing Rewards"
+              corner={null}


Pas de ça null, autant juste ne pas le définir et mettre une valeur de base dans le composant

fricoben · 2023-07-16T16:08:44Z

components/UI/titles/categoryTitle.tsx

+  title: string;
+  subtitle: string;
+  corner?: string | null;
+  squares?: string | null;


Pas de null, y'a déjà undefined avec le ?: qui fait le taff

fricoben

Almost there ! Just some few things to clean.

fricoben · 2023-07-17T14:06:29Z

components/UI/steps/stepElement.tsx

+              <h2 key={`step_${index}_subtitle`} className={styles.subtitle}>
+                {step.subtitle}
+              </h2>,
+            ].sort(() => (subTitleBefore ? -1 : 1))}


Pourquoi cette logique ? C'est trop compliqué encore selon moi. Essayes de penser à qlq chose de plus simple dans le css notamment.

fricoben · 2023-07-17T14:07:45Z

components/UI/steps/stepElement.tsx

+          </div>
+          <div className={styles.overlay}>
+            {step.overlay ? step.overlay : null}
+          </div>


{ step.overlay ? <div className={styles.overlay}> step.overlay </div> : null }

C'est mieux ça nous fait une div en moins

fricoben · 2023-07-17T14:12:18Z

components/UI/titles/mainTitle.tsx

+  highlighted,
+  subtitle,
+  corner = null,
+  squares = null,


= null ne sert à rien.

Ce = est là pour dire si undefined je met quoi comme valeur, donc la si undefined tu met une valeur par defaut et de cette manière tu peux delete corner &&et squares &&.

Si tu veux ne pas en avoir autant ne pas mettre le composant.

Ah oui pardon, j'avais enlevé de l'autre composant, mais apparemment j'ai oublié celui ci

fricoben · 2023-07-17T14:13:37Z

components/pages/home/howToParticipate.tsx

+import Steps from "../../UI/steps/steps";
+import CategoryTitle from "../../UI/titles/categoryTitle";
+import Crosses from "../../shapes/crosses";
+


Ne pas sauter de ligne ici

fricoben · 2023-07-17T14:17:03Z

components/shapes/cross.tsx

+const Cross = () => {
+  return (
+    <svg
+      className={[styles.shape, styles.corner].join(" ")}


Au lieu d'utiliser .join("") il vaut mieux utiliser className={${styles.shape} ${styles.corner}}

Je trouve ça plus clean tu en penses quoi ? Si toi aussi let's go changer tous tes join("") de cette manière là !

fricoben · 2023-07-17T14:18:02Z

components/shapes/dots.tsx

+  number = 5,
+}: {
+  number?: number;
+}) => {


Why do you need ?

: { number?: number; })

Ah mince, j'ai oublié de suppr ça aussi

fricoben · 2023-07-17T14:18:50Z

pages/partnership.tsx

+import OnScrollIntoView from "../components/animations/onScrollIntoView";
+
+const Partnership: NextPage = () => {
+  const { View: JediSwapBannerLottieView, play: jediSwapBannerLottiePlay } =


Ici tu as dans ton naming JediSwapBannerLottieView et jediSwapBannerLottiePlay

Le premier ne devrait pas avoir de majuscule pour rester cohérent dans le naming

J'ai repris le naming de la lib (de base View et play, y'a une maj sur le premier je suppose car c'est un élément de rendu, un peu comme un component). Je fixe ça

fricoben

Lgtm

Marchand-Nicolas added 10 commits July 11, 2023 17:49

Adding "How to Participate ?" category

4503fc1

responsive

f564d2c

adding vertical bar

cedbe81

replacing PNGs by WEBPs

66b2584

Hiding overflow

360ad79

fixing scrollbar

7f12cbe

updating icons

e1accc9

adding cards animations

64b0102

installing react-intersection-observer

bb3f961

Adding partnership page

53b4b0b

Marchand-Nicolas added 4 commits July 13, 2023 16:53

planet animation

b97022f

Implementing JediSwap Lottie

20650c5

Adding dots animation

4c62dc1

Fixing several warnings

5edb34f

fricoben requested changes Jul 14, 2023

View reviewed changes

Fixing responsive

8e659fc

vercel bot had a problem deploying to Preview – goerli-starknet-quest July 16, 2023 09:25 Failure

vercel bot had a problem deploying to Preview – starknet-quest July 16, 2023 09:27 Failure

Cleaning the code

84250b4

vercel bot had a problem deploying to Preview – starknet-quest July 16, 2023 09:54 Failure

vercel bot had a problem deploying to Preview – goerli-starknet-quest July 16, 2023 09:56 Failure

https://github.com/starknet-id/starknet.quest/pull/96#discussion_r126…

a034489

…3742281

vercel bot had a problem deploying to Preview – goerli-starknet-quest July 16, 2023 09:58 Failure

vercel bot had a problem deploying to Preview – starknet-quest July 16, 2023 10:00 Failure

Cleaning the code

df3eeb2

vercel bot had a problem deploying to Preview – starknet-quest July 16, 2023 10:10 Failure

vercel bot had a problem deploying to Preview – goerli-starknet-quest July 16, 2023 10:12 Failure

Improving responsiveness

703fd90

vercel bot had a problem deploying to Preview – starknet-quest July 16, 2023 11:02 Failure

vercel bot had a problem deploying to Preview – goerli-starknet-quest July 16, 2023 11:03 Failure

Cleaning class names

f038114

vercel bot had a problem deploying to Preview – goerli-starknet-quest July 16, 2023 11:12 Failure

vercel bot had a problem deploying to Preview – starknet-quest July 16, 2023 11:14 Failure

fricoben requested changes Jul 16, 2023

View reviewed changes

Cleaning the code

6e55ba9

vercel bot had a problem deploying to Preview – goerli-starknet-quest July 16, 2023 16:42 Failure

vercel bot had a problem deploying to Preview – starknet-quest July 16, 2023 16:44 Failure

fricoben force-pushed the feat/partnership branch from 6e55ba9 to 70799d9 Compare July 17, 2023 13:31

vercel bot deployed to Preview – starknet-quest July 17, 2023 13:33 View deployment

vercel bot deployed to Preview – goerli-starknet-quest July 17, 2023 13:36 View deployment

Marchand-Nicolas force-pushed the feat/partnership branch from 70799d9 to 6e55ba9 Compare July 17, 2023 13:43

Merge branch 'testnet' into feat/partnership

712b9b6

vercel bot deployed to Preview – starknet-quest July 17, 2023 13:50 View deployment

vercel bot deployed to Preview – goerli-starknet-quest July 17, 2023 13:53 View deployment

responsive

f4f26f3

vercel bot deployed to Preview – starknet-quest July 17, 2023 14:17 View deployment

Marchand-Nicolas added 2 commits July 17, 2023 16:18

renaming

e3af5ba

renaming

9bd2ef3

fricoben requested changes Jul 17, 2023

View reviewed changes

vercel bot deployed to Preview – goerli-starknet-quest July 17, 2023 14:22 View deployment

vercel bot deployed to Preview – starknet-quest July 17, 2023 14:25 View deployment

Cleaning the code

4754547

vercel bot deployed to Preview – goerli-starknet-quest July 17, 2023 14:45 View deployment

vercel bot deployed to Preview – starknet-quest July 17, 2023 14:47 View deployment

fricoben approved these changes Jul 17, 2023

View reviewed changes

fricoben merged commit 401536e into testnet Jul 17, 2023
2 checks passed

Feat/partnership #96

Feat/partnership #96

Conversation

Marchand-Nicolas commented Jul 13, 2023

vercel bot commented Jul 13, 2023

fricoben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Jul 16, 2023 • edited Loading

fricoben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fricoben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fricoben left a comment

Choose a reason for hiding this comment

vercel bot commented Jul 16, 2023 •

edited

Loading