Boosts Quest Count Mismatch #818
Conversation
|
@mystical-prog is attempting to deploy a commit to the StarknetID Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent changes enhance the logic for tracking completed boosts by refining the criteria used to determine which boosts are counted. Now, boosts are only considered if they are valid and within the last three weeks, improving both the accuracy of the count and its representation in the user interface. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
components/pages/home/questAndCollectionTabs.tsx (1)
227-233: Improve pluralization logic for "Boosts".The current logic for pluralizing "Boosts" could be improved to ensure it correctly reflects the number of boosts. Consider using a utility function or a more concise conditional expression.
- `${completedBoostNumber}/${displayBoosts.length} Boost${ - boosts.length > 1 ? "s" : "" - } done` + `${completedBoostNumber}/${displayBoosts.length} Boost${displayBoosts.length !== 1 ? "s" : ""} done`
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- components/pages/home/questAndCollectionTabs.tsx (2 hunks)
Additional comments not posted (1)
components/pages/home/questAndCollectionTabs.tsx (1)
Line range hint
1-238: Overall changes approved with a suggestion to verify logic integration.The changes effectively address the issue of quest count mismatches by refining the logic for completed boosts and updating the display accordingly. Ensure that the logic is consistently applied throughout the codebase and verify that all related functionalities are correctly integrated.
| () => boosts?.filter((b) => completedBoostIds?.includes(b.id) && ((new Date().getTime() - boost.expiry) / MILLISECONDS_PER_WEEK <= 3 && | ||
| boost.expiry < Date.now())).length, |
There was a problem hiding this comment.
Review the expiry condition logic.
The condition (new Date().getTime() - boost.expiry) / MILLISECONDS_PER_WEEK <= 3 && boost.expiry < Date.now() seems to have a logical error. The check should ensure that the boost is not expired rather than checking if it's within the last three weeks and expired. Consider revising the logic to accurately reflect the intended condition.
- () => boosts?.filter((b) => completedBoostIds?.includes(b.id) && ((new Date().getTime() - boost.expiry) / MILLISECONDS_PER_WEEK <= 3 &&
- boost.expiry < Date.now())).length,
+ () => boosts?.filter((b) => completedBoostIds?.includes(b.id) && (boost.expiry - new Date().getTime()) / MILLISECONDS_PER_WEEK <= 3).length,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| () => boosts?.filter((b) => completedBoostIds?.includes(b.id) && ((new Date().getTime() - boost.expiry) / MILLISECONDS_PER_WEEK <= 3 && | |
| boost.expiry < Date.now())).length, | |
| () => boosts?.filter((b) => completedBoostIds?.includes(b.id) && (boost.expiry - new Date().getTime()) / MILLISECONDS_PER_WEEK <= 3).length, |
|
Sorry, someone has already been assigned for this issue (in the context of the Only Dust hackathon) |
No worries, but I opened up this PR before OD Hack started and the target issue was not having OD Hack label, nevertheless thank you |
I'm really sorry to hear that. We'll pay more attention to that for the next hackathon. Thank you for telling me |
Boosts Quest Collection Display Info Mismatch Fixed
I have made necessary changes in the
components/pages/home/questAndCollectionTabs.tsxfile wherein I have modified the filter for completedBoostQuests to consider expiry of the quests. I have also changed the state to render on the page fromboosts.lengthtodisplayBoosts.lengthto show the correct count. These changes achieve the desired fixes.Resolves: #804
Summary by CodeRabbit