fix: back button works on Collection quest #806
Conversation
|
@martinvibes is attempting to deploy a commit to the StarknetID Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent changes enhance user experience by improving navigation and tab state persistence within the application. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Category
participant Router
participant LocalStorage
User->>Category: Click BackButton
Category->>LocalStorage: Check activeTab
alt activeTab exists
LocalStorage-->>Category: Return activeTab
Category->>Router: Navigate to corresponding route
else no activeTab
Category->>Router: Call router.back()
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- app/categories/[category]/category.tsx (1 hunks)
- components/pages/home/questAndCollectionTabs.tsx (1 hunks)
Additional comments not posted (3)
app/categories/[category]/category.tsx (1)
50-50: LGTM!The changes to the
BackButtoncomponent are appropriate and align with the new functionality introduced by thehandleBackfunction.components/pages/home/questAndCollectionTabs.tsx (2)
41-43: LGTM!The changes to the
tabIndexstate initialization are appropriate and enhance the user experience by preserving the user's state.
49-49: LGTM!The changes to the
handleChangeTabfunction are appropriate and ensure that the active tab state is maintained even after page reloads.
| const handleBack = () => { | ||
| const activeTab = localStorage.getItem("activeTab"); | ||
| if (activeTab) { | ||
| const tabRoutes = ["/", "/", "/"]; | ||
| router.push(tabRoutes[parseInt(activeTab, 10)]); | ||
| } else { | ||
| router.back(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Consider externalizing the tabRoutes array.
To improve maintainability, consider defining the tabRoutes array outside the function or in a configuration file. This will make it easier to update routes in the future.
const tabRoutes = ["/", "/", "/"];
const handleBack = () => {
const activeTab = localStorage.getItem("activeTab");
if (activeTab) {
router.push(tabRoutes[parseInt(activeTab, 10)]);
} else {
router.back();
}
};
|
@fricoben ready |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/categories/[category]/category.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/categories/[category]/category.tsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
hello @fricoben i saw that you reopened the issue |
kindly review @fricoben @revengexd
Summary by CodeRabbit
New Features
Style