test: get user achievements function #795
Conversation
|
@NueloSE is attempting to deploy a commit to the StarknetID Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis change introduces a robust test suite for the Changes
Assessment against linked issues
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
tests/services/apiService.test.js (2)
3255-3255: Fix the typo in the test description.The test description contains a typo: "retun" should be "return".
- it('should fetch and retun user achievement data', async() => { + it('should fetch and return user achievement data', async() => {
3527-3527: Fix the typo in the test description.The test description contains a typo: "retun" should be "return".
- it('should fetch and retun default user achievement data', async() => { + it('should fetch and return default user achievement data', async() => {
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/services/apiService.test.js (2 hunks)
Additional comments not posted (2)
tests/services/apiService.test.js (2)
3798-3810: LGTM!The test case correctly handles and returns data in an invalid format.
3812-3824: LGTM!The test case correctly handles null and undefined cases.
|
Hello @fricoben i have been unable to make any calls to the api for getUserAchievementByCategory. Can i get some aassistance on this?? |
checking with the back-end team and I'll comeback to you |
As said on Telegram, the |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (29)
services/apiService.ts (29)
Line range hint
1-9:
Ensure proper error handling for API calls.The functions
fetchLeaderboardToppersandfetchLeaderboardRankingslog errors but do not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching leaderboard position", err); + throw new Error("Error while fetching leaderboard position: " + err.message); - console.log("Error while fetching leaderboard ranks", err); + throw new Error("Error while fetching leaderboard ranks: " + err.message);
Line range hint
11-13:
Ensure proper error handling for API calls.The function
getBoostslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching boosts", err); + throw new Error("Error while fetching boosts: " + err.message);
Line range hint
15-17:
Ensure proper error handling for API calls.The function
getQuestsInBoostlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching quests in boost", err); + throw new Error("Error while fetching quests in boost: " + err.message);
Line range hint
19-21:
Ensure proper error handling for API calls.The function
getBoostByIdlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching boost data", err); + throw new Error("Error while fetching boost data: " + err.message);
Line range hint
23-27:
Ensure proper error handling for API calls.The function
getQuestParticipantslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching total participants", err); + throw new Error("Error while fetching total participants: " + err.message);
Line range hint
29-31:
Ensure proper error handling for API calls.The function
getQuestBoostClaimParamslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching claim signature", err); + throw new Error("Error while fetching claim signature: " + err.message);
Line range hint
33-35:
Ensure proper error handling for API calls.The function
getPendingBoostClaimslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching pending claims", err); + throw new Error("Error while fetching pending claims: " + err.message);
Line range hint
37-41:
Ensure proper error handling for API calls.The function
getCompletedBoostslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching completed boosts", err); + throw new Error("Error while fetching completed boosts: " + err.message);
Line range hint
43-45:
Ensure proper error handling for API calls.The function
getQuestslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching trending quests", err); + throw new Error("Error while fetching trending quests: " + err.message);
Line range hint
47-53:
Ensure proper error handling for API calls.The function
getTrendingQuestslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching trending quests", err); + throw new Error("Error while fetching trending quests: " + err.message);
Line range hint
55-57:
Ensure proper error handling for API calls.The function
getCompletedQuestslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching completed quests", err); + throw new Error("Error while fetching completed quests: " + err.message);
Line range hint
59-61:
Ensure proper error handling for API calls.The function
getBoostedQuestslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while getting boosted quests", err); + throw new Error("Error while getting boosted quests: " + err.message);
Line range hint
63-65:
Ensure proper error handling for API calls.The function
getUserAchievementslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching user achievements", err); + throw new Error("Error while fetching user achievements: " + err.message);
Line range hint
67-73:
Ensure proper error handling for API calls.The function
verifyUserAchievementlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while verifying user achievement by category", err); + throw new Error("Error while verifying user achievement by category: " + err.message);
Line range hint
75-77:
Ensure proper error handling for API calls.The function
fetchBuildingslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching buildings data", err); + throw new Error("Error while fetching buildings data: " + err.message);
Line range hint
79-85:
Ensure proper error handling for API calls.The function
getQuizByIdlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching quiz data by Id", err); + throw new Error("Error while fetching quiz data by Id: " + err.message);
Line range hint
87-91:
Ensure proper error handling for API calls.The function
getTasksByQuestIdlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching tasks by quest Id", err); + throw new Error("Error while fetching tasks by quest Id: " + err.message);
Line range hint
93-95:
Ensure proper error handling for API calls.The function
getDeployedTimeByAddresslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching deployed time by address", err); + throw new Error("Error while fetching deployed time by address: " + err.message);
Line range hint
97-101:
Ensure proper error handling for API calls.The function
getEligibleRewardslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching eligible rewards", err); + throw new Error("Error while fetching eligible rewards: " + err.message);
Line range hint
103-105:
Ensure proper error handling for API calls.The function
getQuestActivityDatalogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching quest data", err); + throw new Error("Error while fetching quest data: " + err.message);
Line range hint
107-111:
Ensure proper error handling for API calls.The function
getQuestsParticipationlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching quest participation", err); + throw new Error("Error while fetching quest participation: " + err.message);
Line range hint
113-115:
Ensure proper error handling for API calls.The function
getUniqueVisitorCountlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching unique visitor count", err); + throw new Error("Error while fetching unique visitor count: " + err.message);
Line range hint
117-123:
Ensure proper error handling for API calls.The function
getQuestByIdlogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error parsing quest data:", error); + throw new Error("Error parsing quest data: " + error.message);
Line range hint
125-131:
Ensure proper error handling for API calls.The function
fetchQuestCategoryDatalogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error parsing quest data:", error); + throw new Error("Error parsing quest data: " + error.message);
Line range hint
133-135:
Ensure proper error handling for API calls.The function
updateUniqueVisitorslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching unique visitor count", err); + throw new Error("Error while fetching unique visitor count: " + err.message);
Line range hint
137-141:
Ensure proper error handling for API calls.The function
getDerivatesStatslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching derivatives stats", err); + throw new Error("Error while fetching derivatives stats: " + err.message);
Line range hint
143-147:
Ensure proper error handling for API calls.The function
getLendingStatslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching lending stats", err); + throw new Error("Error while fetching lending stats: " + err.message);
Line range hint
149-153:
Ensure proper error handling for API calls.The function
getPairingStatslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching pairing stats", err); + throw new Error("Error while fetching pairing stats: " + err.message);
Line range hint
155-159:
Ensure proper error handling for API calls.The function
getAltProtocolStatslogs errors but does not handle them effectively. Consider returning an appropriate error response or throwing an error.- console.log("Error while fetching alt protocol stats", err); + throw new Error("Error while fetching alt protocol stats: " + err.message);
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- services/apiService.ts (1 hunks)
- tests/services/apiService.test.js (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- tests/services/apiService.test.js
test
Please add the labels corresponding to the type of changes your PR introduces:
Resolves: #773
Summary by CodeRabbit
Bug Fixes
getUserAchievementByCategoryfunction, streamlining the API's approach to user achievements.Tests
getUserAchievementsfunctionality, validating various scenarios such as successful data retrieval and handling of invalid formats.