ref: change clickable to indexer #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Th0rgal
requested changes
Aug 25, 2023
| <div | ||
| className={styles.clickableIconDiscord} | ||
| onClick={() => | ||
| window.open(`https://discord.com/channels/@me/${discordId}`) |
There was a problem hiding this comment.
I don't think this will work, iirc this undocumented discord endpoint takes a channel id, not a user id. It might be possible to get a channel id from a discord id though.
There was a problem hiding this comment.
I tested I think it worked (it's been a long time since this is in production).
There was a problem hiding this comment.
It didn't for me. Lemme know if you have a working example
fricoben
force-pushed
the
ref/change-clickable
branch
from
13a12fc
to
30d44f9
Compare
fricoben
force-pushed
the
ref/change-clickable
branch
from
30d44f9
to
900e01e
Compare
fricoben
force-pushed
the
ref/change-clickable
branch
from
900e01e
to
dc68bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #131