Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: the broken starkscan links in deployed contracts #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: the broken starkscan links in deployed contracts #41

wants to merge 2 commits into from

Conversation

hemantwasthere
Copy link

Fixes: #40

  • Fixed the Starkscan broken link for Deployed Contracts > Starknet Mainnet > Naming
  • Added the (View on Starkscan) button in Deployed Contracts > Sepolia > Tax Contract

@vercel Vercel
Copy link

vercel bot commented May 9, 2024

@hemantwasthere is attempting to deploy a commit to the StarknetID Team on Vercel.

A member of the Team first needs to authorize it.

@hemantwasthere hemantwasthere changed the title Fixed the broken starkscan links in deployed contracts Fix: the broken starkscan links in deployed contracts May 9, 2024
fricoben
fricoben approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fricoben
fricoben requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thx for the PR but you need to resolve conflicts before merging

fricoben
fricoben approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fricoben
fricoben approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fricoben
fricoben requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflcts and we're good

@fricoben fricoben added the ❌ Change request Change requested from reviewer label Sep 30, 2024
@hemantwasthere
Copy link
Author

okay will do

@hemantwasthere
Copy link
Author

resolved!

@hemantwasthere
Copy link
Author

Please review it @fricoben

@hemantwasthere
Copy link
Author

Hey @fricoben, please lmk if there are anymore changes that are required!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricoben fricoben fricoben requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
❌ Change request Change requested from reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Some Starkscan links are broken in deployed contracts section
2 participants
@hemantwasthere @fricoben