Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kedro #6

Merged
merged 24 commits into from
Oct 15, 2024
Merged

Kedro #6

merged 24 commits into from
Oct 15, 2024

Conversation

stroblme
Copy link
Collaborator

@stroblme stroblme commented Oct 14, 2024

This PR adds kedro based on the existing implementation in qallse_wrapper and its dependencies.
It requires updating the hepqr-qallse repository, such that it can be installed as a package (see separate PR here).

@stroblme stroblme requested a review from majafranz October 14, 2024 20:36
@stroblme
Copy link
Collaborator Author

shall we have .vscode in ignore? I personally prefer sharing settings etc. but don't have a strong opinion on that.
https://stackoverflow.com/questions/32964920/should-i-commit-the-vscode-folder-to-source-control

@majafranz
Copy link
Member

shall we have .vscode in ignore? I personally prefer sharing settings etc. but don't have a strong opinion on that. https://stackoverflow.com/questions/32964920/should-i-commit-the-vscode-folder-to-source-control

Idk, if you prefer it, we can have this un-ignored :D I think this is up to the vscode user to decide.

@stroblme
Copy link
Collaborator Author

kk, if there are no reasons against it, then let's keep it because it simplifies my workflow a little bit.. However, feel free to change later if it's somehow annoying os.

Signed-off-by: lc3267 <[email protected]>
@stroblme
Copy link
Collaborator Author

stroblme commented Oct 15, 2024

is /main.py actually still in use or is this a leftover?

Signed-off-by: lc3267 <[email protected]>
@majafranz
Copy link
Member

is /main.py actually still in use or is this a leftover?

Ah there are a few leftovers. The main.py in src/qallse_wrapper is also one

@majafranz majafranz merged commit 0b52759 into main Oct 15, 2024
@majafranz majafranz deleted the kedro branch October 16, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants