Redesign of GEDF scheduler #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
It didn't run on Linux. Looks like a problem with propagation of deadlines across federates! We were masking this problem by having a flawed scheduler... |
Actually, the situation looks worse. Deadlines are not propagated anywhere! ReactorInstance.assignDeadlines is never called anywhere in the code generation tree. |
|
Oh you're right. I must have looked at the wrong CI output 🫣 |
petervdonovan
approved these changes
May 27, 2024
petervdonovan
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a companion PR in lingua-franca.
This a PR addresses issue #426, which points out that the GEDF scheduler was not prioritizing reactions with tighter deadlines unless they also had the same or lower levels compared to reactions with looser deadlines. It also fixes a bug (exposed by the change to GEDF) where deadlines were not propagated upstream to reactions that lexically precede a reaction with a deadline.
This scheduler also achieves slightly better performance than the previous scheduler (390 ns/reaction vs. 450 ns/reaction on a performance test).
This PR also cleans up scheduler_instance.h, removing several items that are relevant only to specific schedulers and are not part of the scheduling API. There are also various other code cleanups.
This PR also removes the chain_ID field of reactions, which never worked.