Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexpret docs #254

Merged
merged 11 commits into from
May 23, 2024
Merged

Add flexpret docs #254

merged 11 commits into from
May 23, 2024

Conversation

magnmaeh
Copy link
Member

@magnmaeh magnmaeh commented Apr 22, 2024

A draft ready in the case that

lf-lang/reactor-c#412
lf-lang/lingua-franca#2262

get merged. With this PR we should also create a template repository like https://github.com/lf-lang/lf-west-template, just for FlexPRET.

I don't know much about webpages so not quite sure how it's done with the versioned docs part.

@magnmaeh
Copy link
Member Author

@lhstrh Do you think it would be possible to create a lf-flexpret-template repository under the lf-lang organization and give me access to it so I can start developing that one as well? :) If that's something you're allowed to do

@lhstrh
Copy link
Member

lhstrh commented Apr 23, 2024

Great idea! The best way to do this is probably to create it under your own account. Then, when it is ready to use, simply transfer the repo to the lf-lang org, and it will become available there.

@magnmaeh
Copy link
Member Author

Ah I didn't know that was possible! I'll do that then, thanks! :)

@lhstrh
Copy link
Member

lhstrh commented Apr 23, 2024

Yes, it's super easy. Thanks for all the great work you're doing!! 🚀

@magnmaeh
Copy link
Member Author

No problem, I'm happy to contribute to such a cool project 😀

@magnmaeh
Copy link
Member Author

magnmaeh commented May 4, 2024

@lsk567 Do you think it would make sense to repurpose https://github.com/icyphy/lf-flexpret into a template repository, like https://github.com/lf-lang/lf-west-template? Then we would have to transfer ownership too, though. Or is it better to just start from a fresh repo maybe?

@magnmaeh magnmaeh marked this pull request as ready for review May 19, 2024 09:29
@lsk567
Copy link

lsk567 commented May 19, 2024

@lsk567 Do you think it would make sense to repurpose https://github.com/icyphy/lf-flexpret into a template repository, like https://github.com/lf-lang/lf-west-template? Then we would have to transfer ownership too, though. Or is it better to just start from a fresh repo maybe?

@magnmaeh Sorry for seeing this message late, Magnus. Yes, let's do it as you suggested. Feel free to reorganize lf-flexpret as you see fit.

@magnmaeh
Copy link
Member Author

@lsk567 Do you think it would make sense to repurpose https://github.com/icyphy/lf-flexpret into a template repository, like https://github.com/lf-lang/lf-west-template? Then we would have to transfer ownership too, though. Or is it better to just start from a fresh repo maybe?

@magnmaeh Sorry for seeing this message late, Magnus. Yes, let's do it as you suggested. Feel free to reorganize lf-flexpret as you see fit.

No problem, we decided to just create a new one because the lf-flexpret repo had some Arduino stuff as well :)

@magnmaeh
Copy link
Member Author

magnmaeh commented May 21, 2024

@erlingrj Do you want to review this?
(I cannot assign anyone here)

@erlingrj
Copy link
Collaborator

Will review tomorrow

Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs! Just a few nitpicks

docs/embedded/flexpret.mdx Outdated Show resolved Hide resolved
docs/embedded/flexpret.mdx Outdated Show resolved Hide resolved
docs/embedded/flexpret.mdx Outdated Show resolved Hide resolved
@erlingrj erlingrj merged commit 6e31ff3 into lf-lang:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants