Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support lookup ping api (#2791) #3038

Closed
wants to merge 4 commits into from

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 23, 2024

No description provided.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 60.80692% with 136 lines in your changes missing coverage. Please review.

Project coverage is 67.93%. Comparing base (88fd5da) to head (19e419c).
Report is 54 commits behind head on master.

Files Patch % Lines
internal/server/yaml_import_export.go 62.72% 53 Missing and 10 partials ⚠️
extensions/impl/sql/lookupSource.go 68.03% 32 Missing and 7 partials ⚠️
internal/server/meta_init.go 5.88% 16 Missing ⚠️
internal/topo/node/node.go 0.00% 10 Missing ⚠️
internal/server/rest.go 42.86% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
- Coverage   67.97%   67.93%   -0.04%     
==========================================
  Files         353      354       +1     
  Lines       34242    34575     +333     
==========================================
+ Hits        23273    23487     +214     
- Misses       8898     8997      +99     
- Partials     2071     2091      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying changed the base branch from v2 to master July 23, 2024 07:11
@Yisaer Yisaer closed this Jul 23, 2024
@Yisaer Yisaer reopened this Jul 23, 2024
@Yisaer Yisaer closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant